Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install directory, address #116 #120

Merged
merged 1 commit into from
Nov 15, 2019

Conversation

wxmerkt
Copy link
Member

@wxmerkt wxmerkt commented Nov 15, 2019

The issue underlying #116 is that:

  1. The library gets installed to ${CMAKE_INSTALL_PREFIX}/lib
  2. However, the use of GNUInstallDirs inside the cmake/base.cmake sets the variable defining what gets set in the pkg-config template to use the FULL variables. These get set to include the prefix on some platforms (and old versions of debhelper).
  3. As a result there is a mismatch between what the eigenpy.pc says for where the library and pkg-config files are and where they actually get installed.

This took quite some time to debug...

The pkg-config template uses the _FULL_ variables while the install happens without the prefix.
This addresses stack-of-tasks#116
@wxmerkt
Copy link
Member Author

wxmerkt commented Nov 15, 2019

@nim65s Will this be fine for you guys? I reckon this issue may lurk in other cmakemodules depending projects as well...

Copy link
Contributor

@jcarpent jcarpent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for me. I think @seanyen won't be affected by these changes and neither for LAAS side.
I will merge it and may create a new release.
@wxmerkt Is it OK for you?

@jcarpent
Copy link
Contributor

@wxmerkt Thanks a lot for fixing this annoying bug.

@nim65s
Copy link
Contributor

nim65s commented Nov 15, 2019

If it fixes the build for you, and if that's the right way to do it, then it's ok for me.
For robotpkg, I don't think it will change something, and if it does, I will be able to override it anyway :)

@nim65s
Copy link
Contributor

nim65s commented Nov 15, 2019

(i would have preferred shorter things like lib to ${CMAKE_INSTALL_FULL_INCLUDEDIR}, but this is not relevant for now.)

@jcarpent
Copy link
Contributor

@nim65s Thanks for your feedback.

@jcarpent jcarpent merged commit c021d21 into stack-of-tasks:devel Nov 15, 2019
@wxmerkt
Copy link
Member Author

wxmerkt commented Nov 15, 2019

Thank you guys! @jcarpent Can you please increment the package.xml and make a new release? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants