Make sure no one can show the chrome if the default setting is hidden.

add tests Fixes elastic#13040
stacey-gammon · Aug 1, 2017 · e4842bf · e4842bf
1 parent d36080b
commit e4842bf
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 1 deletion.
diff --git a/src/ui/public/chrome/api/controls.js b/src/ui/public/chrome/api/controls.js
@@ -19,6 +19,10 @@ export default function (chrome, internals) {
    * @return {chrome}
    */
   chrome.setVisible = function (display) {
+    if (!def) {
+      // If the default chrome visibility is off, we don't want it to ever appear.
+      return;
+    }
     internals.visible = Boolean(display);
     return chrome;
   };

diff --git a/src/ui/public/chrome/directives/kbn_chrome.html b/src/ui/public/chrome/directives/kbn_chrome.html
@@ -1,6 +1,7 @@
 <div class="content" chrome-context data-test-subj="kibanaChrome">
   <global-nav
     chrome="chrome"
+    data-test-subj="globalNav"
     is-visible="chrome.getVisible()"
     logo-brand="chrome.getBrand('logo')"
     small-logo-brand="chrome.getBrand('smallLogo')"

diff --git a/test/functional/apps/dashboard/_dashboard.js b/test/functional/apps/dashboard/_dashboard.js
@@ -190,6 +190,32 @@ export default function ({ getService, getPageObjects }) {
       });
     });
 
+    describe('embed mode', () => {
+      it('hides the chrome', async () => {
+        let isChromeVisible = await PageObjects.common.isChromeVisible();
+        expect(isChromeVisible).to.be(true);
+
+        const currentUrl = await remote.getCurrentUrl();
+        const newUrl = currentUrl + '&embed=true';
+        // Embed parameter only works on a hard refresh.
+        const useTimeStamp = true;
+        await remote.get(newUrl.toString(), useTimeStamp);
+
+        await retry.try(async () => {
+          isChromeVisible = await PageObjects.common.isChromeVisible();
+          expect(isChromeVisible).to.be(false);
+        });
+      });
+
+      after(async function () {
+        const currentUrl = await remote.getCurrentUrl();
+        const newUrl = currentUrl.replace('&embed=true', '');
+        // Remove the timestamp so the rest of the tests retain state across app navigation.
+        const useTimeStamp = false;
+        await remote.get(newUrl.toString(), useTimeStamp);
+      });
+    });
+
     describe('add new visualization link', () => {
       it('adds a new visualization', async () => {
         await PageObjects.dashboard.clickAddVisualization();

diff --git a/test/functional/page_objects/common_page.js b/test/functional/page_objects/common_page.js
@@ -257,7 +257,9 @@ export function CommonPageProvider({ getService, getPageObjects }) {
     }
 
     async isChromeVisible() {
-      return await testSubjects.exists('kibanaChrome');
+      const globalNavShown = await testSubjects.exists('globalNav');
+      const topNavShown = await testSubjects.exists('top-nav');
+      return globalNavShown && topNavShown;
     }
 
     async waitForTopNavToBeVisible() {