Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rededge1,2,3 to common names #19

Closed
m-mohr opened this issue Dec 8, 2022 · 1 comment · Fixed by #22
Closed

Add rededge1,2,3 to common names #19

m-mohr opened this issue Dec 8, 2022 · 1 comment · Fixed by #22
Assignees
@emmanuelmathot @m-mohr
Milestone
2.0.0

Comments

@m-mohr
Copy link
Contributor

m-mohr commented Dec 8, 2022

It's a bit weird that the common name rededge has 3 bands included for S2, which is not ideal if you try to identify bands based on the common names.
The great repository Awesome Spectral Indices splits the rededge into 3 parts: Red Edge 1, 2 and 3.
I'd propose to add these three in addition.
@m-mohr m-mohr changed the title Add redgedge1,2,3 to common names Add rededge1,2,3 to common names Jan 5, 2023
m-mohr added a commit that referenced this issue Jan 9, 2023
@m-mohr
Added rededge 1-3 as common names #19
e4125d1
@m-mohr m-mohr mentioned this issue Jan 9, 2023
Merged
m-mohr added a commit that referenced this issue Jan 9, 2023
@m-mohr
Added rededge 1-3 as common names #19
252f9b5
@m-mohr m-mohr linked a pull request Jan 9, 2023 that will close this issue
Update common band names table #22
Merged
@davemlz davemlz mentioned this issue Feb 3, 2023
Closed
@matthewhanson
Copy link
Member

Discussed in STAC sprint

@emmanuelmathot to create draft PR for v2.0 of this extension which will remove eo:bands for compliance with upcoming STAC 1.1 - see radiantearth/stac-spec#1254

@emmanuelmathot emmanuelmathot mentioned this issue Sep 28, 2023
Closed
2 tasks
@davemlz davemlz mentioned this issue Feb 13, 2024
Closed
@m-mohr m-mohr added this to the 2.0.0 milestone Jul 8, 2024
@m-mohr m-mohr mentioned this issue Jul 31, 2024
Closed
m-mohr added a commit that referenced this issue Aug 1, 2024
@m-mohr
Update common band names table (#22)
5cdfce6 
* Added rededge 1-3 as common names #19

* Update names

* Updated mapping based on https://eoreader.readthedocs.io/en/v0.19.1/optical_band_mapping.html

* Fix table and changelog

* Added more sats, restructuring

* Add green05, add Worldview 2/3, small changes in wavelength ranges

* Common names should be unique
@m-mohr m-mohr closed this as completed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emmanuelmathot emmanuelmathot

@m-mohr m-mohr

Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Update common band names table stac-extensions/eo
3 participants
@emmanuelmathot @matthewhanson @m-mohr