🐛 Fix lastCommit optional author details bug

staart · Oct 27, 2019 · 149f66e · 149f66e
1 parent a487a77
commit 149f66e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@staart/site",
-  "version": "1.0.8",
+  "version": "1.1.1",
   "module": "dist/module.js",
   "main": "dist/index.js",
   "bin": "./dist/index.js",

diff --git a/src/generator.ts b/src/generator.ts
@@ -213,7 +213,7 @@ const generatePage = async (path: string, content: string) => {
   if (!config.noLastModified) {
     const lastCommit = await getLastCommit(path);
     const githubUrl = await getGitHubRepoUrl();
-    if (lastCommit)
+    if (lastCommit && lastCommit.author && lastCommit.commit)
       content += `\n\n<p class="post-footer">This page was last modified in <a href="${
         lastCommit.html_url
       }" target="_blank">${lastCommit.sha.substr(0, 6)}</a> by <a href="${

diff --git a/src/github.ts b/src/github.ts
@@ -15,13 +15,13 @@ export const getLastCommit = async (
   | {
       html_url: string;
       sha: string;
-      author: {
+      author?: {
         login: string;
         name: string;
         avatar_url: string;
         html_url: string;
       };
-      commit: {
+      commit?: {
         message: string;
         author: {
           name: string;