Create QueryReflection lazily to prevent eager creation of a database connection

[staabm]

prevents a exception while the rule is instantiated

$ vendor-bin/phpstan/vendor/bin/phpstan analyse -c deploy-phpstan.neon.dist --no-progress --debug
C:\dvl\Workspace\kunzmann\deploy.php
Uncaught staabm\PHPStanDba\DbaException: Reflector not initialized. Make sure a phpstan bootstrap file is configured which calls staabm\PHPStanDba\QueryReflection\QueryReflection::setupReflector(). in C:\dvl\Workspace\kunzmann\vendor-bin\phpstan\vendor\staabm\phpstan-dba\src\QueryReflection\QueryReflection.php:517
#0 C:\dvl\Workspace\kunzmann\vendor-bin\phpstan\vendor\staabm\phpstan-dba\src\QueryReflection\QueryReflection.php(66): staabm\PHPStanDba\QueryReflection\QueryReflection::reflector()
#1 C:\dvl\Workspace\kunzmann\vendor-bin\phpstan\vendor\staabm\phpstan-dba\src\Rules\DoctrineKeyValueStyleRule.php(58): staabm\PHPStanDba\QueryReflection\QueryReflection->__construct()
#2 C:\Users\mstaab\AppData\Local\Temp\phpstan\cache\nette.configurator\Container_0fd9d387b1.php(5547): staabm\PHPStanDba\Rules\DoctrineKeyValueStyleRule->__construct()
#3 phar://C:/dvl/Workspace/kunzmann/vendor-bin/phpstan/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Container.php(162): Container_0fd9d387b1->createService0446()
#4 phar://C:/dvl/Workspace/kunzmann/vendor-bin/phpstan/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Container.php(95): _PHPStan_8260032bc\Nette\DI\Container->createService()
#5 phar://C:/dvl/Workspace/kunzmann/vendor-bin/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/DependencyInjection/Nette/NetteContainer.php(33): _PHPStan_8260032bc\Nette\DI\Container->getService()
#6 phar://C:/dvl/Workspace/kunzmann/vendor-bin/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/DependencyInjection/Nette/NetteContainer.php(88): PHPStan\DependencyInjection\Nette\NetteContainer->getService()
#7 [internal function]: PHPStan\DependencyInjection\Nette\NetteContainer->PHPStan\DependencyInjection\Nette\{closure}()
#8 phar://C:/dvl/Workspace/kunzmann/vendor-bin/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/DependencyInjection/Nette/NetteContainer.php(89): array_map()
#9 phar://C:/dvl/Workspace/kunzmann/vendor-bin/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/DependencyInjection/Nette/NetteContainer.php(58): PHPStan\DependencyInjection\Nette\NetteContainer->tagsToServices()
#10 phar://C:/dvl/Workspace/kunzmann/vendor-bin/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/DependencyInjection/MemoizingContainer.php(42): PHPStan\DependencyInjection\Nette\NetteContainer->getServicesByTag()
#11 phar://C:/dvl/Workspace/kunzmann/vendor-bin/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Rules/LazyRegistry.php(61): PHPStan\DependencyInjection\MemoizingContainer->getServicesByTag()
#12 phar://C:/dvl/Workspace/kunzmann/vendor-bin/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Rules/LazyRegistry.php(37): PHPStan\Rules\LazyRegistry->getRulesFromContainer()
#13 phar://C:/dvl/Workspace/kunzmann/vendor-bin/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/FileAnalyser.php(104): PHPStan\Rules\LazyRegistry->getRules()
#14 phar://C:/dvl/Workspace/kunzmann/vendor-bin/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/FileAnalyser.php(174): PHPStan\Analyser\FileAnalyser->PHPStan\Analyser\{closure}()
#15 phar://C:/dvl/Workspace/kunzmann/vendor-bin/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/Analyser.php(72): PHPStan\Analyser\FileAnalyser->analyseFile()
#16 phar://C:/dvl/Workspace/kunzmann/vendor-bin/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Command/AnalyserRunner.php(62): PHPStan\Analyser\Analyser->analyse()
#17 phar://C:/dvl/Workspace/kunzmann/vendor-bin/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Command/AnalyseApplication.php(209): PHPStan\Command\AnalyserRunner->runAnalyser()
#18 phar://C:/dvl/Workspace/kunzmann/vendor-bin/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Command/AnalyseApplication.php(102): PHPStan\Command\AnalyseApplication->runAnalyser()
#19 phar://C:/dvl/Workspace/kunzmann/vendor-bin/phpstan/vendor/phpstan/phpstan/phpstan.phar/src/Command/AnalyseCommand.php(174): PHPStan\Command\AnalyseApplication->analyse()
#20 phar://C:/dvl/Workspace/kunzmann/vendor-bin/phpstan/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Command/Command.php(259): PHPStan\Command\AnalyseCommand->execute()
#21 phar://C:/dvl/Workspace/kunzmann/vendor-bin/phpstan/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Application.php(870): _PHPStan_8260032bc\Symfony\Component\Console\Command\Command->run()
#22 phar://C:/dvl/Workspace/kunzmann/vendor-bin/phpstan/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Application.php(261): _PHPStan_8260032bc\Symfony\Component\Console\Application->doRunCommand()
#23 phar://C:/dvl/Workspace/kunzmann/vendor-bin/phpstan/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Application.php(157): _PHPStan_8260032bc\Symfony\Component\Console\Application->doRun()
#24 phar://C:/dvl/Workspace/kunzmann/vendor-bin/phpstan/vendor/phpstan/phpstan/phpstan.phar/bin/phpstan(124): _PHPStan_8260032bc\Symfony\Component\Console\Application->run()
#25 phar://C:/dvl/Workspace/kunzmann/vendor-bin/phpstan/vendor/phpstan/phpstan/phpstan.phar/bin/phpstan(125): _PHPStan_8260032bc\{closure}()
#26 C:\dvl\Workspace\kunzmann\vendor-bin\phpstan\vendor\phpstan\phpstan\phpstan(8): require('...')
#27 C:\dvl\Workspace\kunzmann\vendor-bin\phpstan\vendor\bin\phpstan(120): include('...')
#28 {main}

[staabm]

fyi @hemberger

[hemberger]

Do you think we can make the SchemaReflection static in the QueryReflection class then? The reason I made QueryReflection a class property was to avoid recreating the SchemaReflection from scratch for each node we process. Or maybe there's a better way to avoid duplicating the queries that SchemaReflection performs?

[staabm]

We could try moving QueryReflection and SchemaReflection into phpstan DI container