Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECS and apply standard sets #528

Merged
merged 5 commits into from
Feb 18, 2023
Merged

Add ECS and apply standard sets #528

merged 5 commits into from
Feb 18, 2023

Conversation

TomasVotruba
Copy link
Contributor

  • replace cs fixer with ecs
  • update compose run
  • [cs] apply PSR-12 and other sets

@TomasVotruba TomasVotruba changed the title tv ecs Add ECS and apply standard sets Feb 17, 2023
@TomasVotruba
Copy link
Contributor Author

TomasVotruba commented Feb 17, 2023

As request yesterday :)

I see the php-cs-fixer now requires PHP 7.3, which is a pitty. ECS solves this 👍

I've applied all typical comon sets, including PSR 12 and strict types. I think the code is now sooo much better quality 💪
Let me know if there is something you really don't like.

Otherwise it's ready to go 👍

@staabm
Copy link
Owner

staabm commented Feb 18, 2023

Looks great. 🙏

@staabm staabm merged commit a7bc22b into staabm:main Feb 18, 2023
@TomasVotruba TomasVotruba deleted the tv-ecs branch February 18, 2023 09:29
@TomasVotruba
Copy link
Contributor Author

Awesome 👍

@staabm
Copy link
Owner

staabm commented Feb 18, 2023

btw: I have also running a green PHP 7.2 CI job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants