Support iterable typed parameter (#693)

staabm · Oct 28, 2024 · cc1678a · cc1678a
1 parent 0adf44a
commit cc1678a
Show file tree

Hide file tree

Showing 4 changed files with 42 additions and 1 deletion.
diff --git a/src/QueryReflection/QuerySimulation.php b/src/QueryReflection/QuerySimulation.php
@@ -34,7 +34,7 @@ public static function simulateParamValueType(Type $paramType, bool $preparedPar
             return (string) $paramType->getValue();
         }
 
-        if ($paramType->isArray()->yes()) {
+        if ($paramType->isIterable()->yes()) {
             return self::simulateParamValueType($paramType->getIterableValueType(), $preparedParam);
         }
 

diff --git a/tests/default/data/pdo-prepare.php b/tests/default/data/pdo-prepare.php
@@ -136,6 +136,20 @@ public function specifiedArray(PDO $pdo, array $idsToUpdate, string $time)
         assertType('PDOStatement<array{adaid: int<-32768, 32767>, 0: int<-32768, 32767>}>', $stmt);
     }
 
+    /**
+     * @param iterable<int> $idsToUpdate
+     */
+    public function specifiedIterable(PDO $pdo, iterable $idsToUpdate, string $time)
+    {
+        $query = 'SELECT adaid FROM ada WHERE adaid IN (:ids) AND email LIKE :time';
+        $stmt = $pdo->prepare($query);
+        $stmt->execute([
+            'ids' => $idsToUpdate,
+            'time' => $time,
+        ]);
+        assertType('PDOStatement<array{adaid: int<-32768, 32767>, 0: int<-32768, 32767>}>', $stmt);
+    }
+
     public function noInferenceOnBug196(PDO $pdo, array $minorPhpVersions, \DateTimeImmutable $updateDate)
     {
         $sumQueries = [];

diff --git a/tests/rules/UnresolvableQueryMethodRuleTest.php b/tests/rules/UnresolvableQueryMethodRuleTest.php
@@ -78,4 +78,9 @@ public function testBug547(): void
     {
         $this->analyse([__DIR__ . '/data/bug-547.php'], []);
     }
+
+    public function testBug676(): void
+    {
+        $this->analyse([__DIR__ . '/data/bug-676.php'], []);
+    }
 }
diff --git a/tests/rules/data/bug-676.php b/tests/rules/data/bug-676.php
@@ -0,0 +1,22 @@
+<?php
+
+namespace Test;
+
+use Doctrine\DBAL\Connection;
+
+class Test
+{
+    private Connection $connection;
+
+    public function getIds(iterable $ids): array
+    {
+        return $this
+            ->connection
+            ->executeQuery(
+                'SELECT id FROM table WHERE id IN (:list)',
+                ['list' => $ids],
+                ['list' => DBAL\Connection::PARAM_INT_ARRAY],
+            )
+            ->fetchFirstColumn();
+    }
+}