Fix multiline formatting bug

[lenianiva]

Resolves #2

[lenianiva]

This branch replaces \eqnannotationtext with \eqnannotationfont and \eqnannotationstrut with the font part provided to \node[font=\eqnannotationfont]. I have not completely modified the example and PDF yet in order to showcase that it works as intended.

[st--]

Great, thank you so much for contributing - I'll see how it works :)

[st--]

Just to let you know I'm still intending to sort this out!

[lenianiva]

Thanks! (sorry i replied to the wrong thread that is why you see the edit)

[st--]

Hi @vleni ! Thank you so much for fixing this issue. This is basically good to go, I just marked a few changes, mainly for consistency - most of it as review suggestions, so you could just go and accept them from GitHub. The only other thing I couldn't "suggest" directly was removing the now-obsolete workaround - I've left a comment about that.

If you're happy with my suggestions, ping me and I'll merge it in. :)

[st--]

Thanks for fixing it 🎉

[st--]

I don't think it's helpful to show the old work-around - could you just delete it instead? All it needs to say here is that using \\ within the text to get a line break works just fine.:)

[lenianiva]

Thanks! It should be ok now after your change.

[st--]

@vleni if you agree with all the suggestions, you can just go and accept them (see GitHub docs in case that's new to you).

Also, would you be happy to adapt the no-longer-needed section on the workaround (see https://github.com/st--/annotate-equations/pull/11/files#r1105454093) instead of just marking it "obsolete"?

If you prefer, I can also do all those changes myself, but I didn't want to do so without giving you the chance first because it would seem rude to me to edit someone else's contributions for them:)

[st--]

(Side note- I edited the PR description to include "resolves #2" because a) the link to the issue makes it easier to keep up with why this PR is here and what it does and b) GitHub has this neat feature where merging a PR also closes the linked issues :))

[st--]

Oh, one more task: after the final changes, could you also regenerate the PDF & commit that?

Update: I spotted a minor typography issue in the TeX that I fixed on the main branch - you can either merge that into your branch and then regenerate the PDF, or skip generating the PDF & I'll do it separately after merging your PR - either works:)

[lenianiva]

ok I fixed all of the suggestions and I regenerated the PDF but I didn't merge master. Could you do it in the merge commit?

[st--]

looks good!