p2p: start listening to P2P messages only after contract and metadata sync #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkryuchkov
changed the title
nkryuchkov
changed the title
nkryuchkov
commented
Oct 26, 2024
nkryuchkov
commented
Oct 31, 2024
| break | ||
| } | ||
| } | ||
| if !hasMetadata { |
There was a problem hiding this comment.
I'm not sure why but the original logic used to fetch and update if none of the shares have metadata (the !share.Liquidated part of the condition is useless because shares contains non-liquidated shares)
This is changed to fetching all public keys if at least one share metadata is missing, however, probably we want to modify this logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1712