openssl: upgrade bindings package #1800
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkryuchkov
reviewed
Oct 18, 2024
| panic(err) | ||
| } | ||
| } | ||
|
|
||
| // getVersion returns the highest available OpenSSL version. | ||
| func getVersion() string { |
There was a problem hiding this comment.
Can you please add a comment that this code is taken from https://github.com/golang-fips/openssl/blob/v2/openssl_test.go?
There was a problem hiding this comment.
Yup, the reason is https://github.com/golang-fips/openssl doesn't really provide any examples/docs on how this should be done, so I found this approach to work for me (in Docker),
added a note on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches OpenSSL package we use for RSA from https://github.com/microsoft/go-crypto-openssl (now deprecated) to https://github.com/golang-fips/openssl,
according to benchmarks I ran, it doesn't bring any performance improvements though.
We can also close this PR for now, and we can get back to it later on. See #1348 for additional historical context.
Reminder to self, before merging will need to: