Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include 'connected' in peer scores log #1224

Merged
merged 4 commits into from
Dec 17, 2023

Conversation

moshe-blox
Copy link
Contributor

No description provided.

andrew-blox
andrew-blox previously approved these changes Dec 5, 2023
.gitlab-ci.yml Outdated
@@ -40,7 +40,7 @@ Build stage Docker image:
- docker tag $IMAGE_NAME:$CI_COMMIT_SHA $DOCKER_REPO_INFRA_STAGE:$CI_COMMIT_SHA
- $DOCKER_LOGIN_TO_INFRA_STAGE_REPO && docker push $DOCKER_REPO_INFRA_STAGE:$CI_COMMIT_SHA
only:
- stage
- peer-scores-log-connected
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this

y0sher
y0sher previously approved these changes Dec 17, 2023
@moshe-blox moshe-blox merged commit 4a6e3f6 into stage Dec 17, 2023
5 checks passed
@moshe-blox moshe-blox deleted the peer-scores-log-connected branch December 17, 2023 12:42
moshe-blox added a commit that referenced this pull request Jan 2, 2024
* fix: stale operator ID in `p2pNetwork` (#1229)

* fix: stale operator ID in `p2pNetwork`

---------

Co-authored-by: Lior Rutenberg <[email protected]>

* fix: sufficient timeout for initial duty fetch (#1214)

* fix: sufficient timeout for initial duty fetch (#1214)
---------

Co-authored-by: Matus Kysel <[email protected]>

* deployment: change bootnode for holesky-stage (#1233)

* deploy new bootnode ENR for holesky stage

* Voluntary exit (#1200)

* Voluntary exit

---------

Co-authored-by: moshe-blox <[email protected]>
Co-authored-by: olegshmuelov <[email protected]>
Co-authored-by: MatheusFranco99 <[email protected]>

* feat: include 'connected' in peer scores log (#1224)

* feat: include 'connected' in peer scores log

* P2P metrics  (#1163)

* metrics: added p4 score (invalidMessageDeliveries)

* metrics: added total msgs accepted, msgs accepted from peer with Id, signatures verification

* deploy to the stage

# Conflicts:
#	.gitlab-ci.yml

* metrics: added counters flush once in 8h

* metrics: added counters for duties

* Added auto delete disconnected peers label metrics. Added RSA verifications metric

* disabled ci

* Updated p4 score metric update

* metrics: added p4 score (invalidMessageDeliveries)

* metrics: added total msgs accepted, msgs accepted from peer with Id, signatures verification

* deploy to the stage

# Conflicts:
#	.gitlab-ci.yml

* metrics: added counters flush once in 8h

* metrics: added counters for duties

* Added auto delete disconnected peers label metrics. Added RSA verifications metric

* disabled ci

* Updated p4 score metric update

* review comments fixes

* deploy

* deploy

* testing metrics differ

* added duties created and finalized

* removed extra monitoring.metricsreporter usage

* removed topic from p4score. made it a sum of squares

* deploy to all nodes

* deploy p2p_metrics

* pr review fixes

* trigger ci

* deploy 9-20

* Fix msg validation rsa verification counter metric

* allocate p2p_metrics

* inspect scores more frequently, but don't log every time

* renamed duties created/finalized metrics and refactored to record role

* deploy to 5--8

* deploy to 5--8

* rename metric

* blank space

* approve spec change (just a metric)

* refactors

* reset scores

* metric help msg

* revert gitlab

* deploy

* revert deploy

* Add metrics for signature verifications

* Update differ.config.yaml with approved changes

---------

Co-authored-by: Anton Korpusenko <[email protected]>
Co-authored-by: Gal Rogozinski <[email protected]>
Co-authored-by: Matus Kysel <[email protected]>
Co-authored-by: MatheusFranco99 <[email protected]>
Co-authored-by: moshe-blox <[email protected]>

* Node health (#1203)

* chore: link to SSV API docs in configs & README

* initial commit

* add node health route to ssv API

* update health route

* update health route

* update health route

* update health route

* deploy to stage

* add plaintext response

* lint

* lint

* change to good/bad

* lint

* lint

* refactor

* Revert "deploy to stage"

This reverts commit 2f54f4e.

* lint

* add inbound/outbound count for health + deploy to stage

* change ports back

* update count

* lint

* update conns

* lint

* remove connected peer count

* test blocked ports

* Revert "remove connected peer count"

This reverts commit 79e2b94.

* leave only active peers count

* Revert "test blocked ports"

This reverts commit 6fc9282.

* ci to stage

* add mutex to nodes access

* refactor: node health API (#1222)

* refactor: node health API

* added cpu_cores to healthcheck output

* fix inbound/outbound stats

* Remove CPU core reporting

---------

Co-authored-by: moshe-blox <[email protected]>
Co-authored-by: Matus Kysel <[email protected]>
Co-authored-by: moshe-blox <[email protected]>

* feat: subscribe to a random subnet with 0 validators (#1245)

* feat: subscribe to a random subnet with 0 validators

* Fix: health route host addres (#1246)

* node health api route advertises the host addresses from the config.

* set up listenaddress directly

* feat: rate limit inbound connections by IP (#1226)

* feat: rate limit inbound connections by IP

* activate conngater

* deploy to 5--8

* fix

* fix

* Refactor connection gating in p2p setup

* Update ipLimiter parameters

* revert gitlab

* Revert "revert gitlab"

This reverts commit fcc7902.

* Revert "Revert "revert gitlab""

This reverts commit feb9e4e.

---------

Co-authored-by: Gal Rogozinski <[email protected]>

---------

Co-authored-by: moshe-blox <[email protected]>
Co-authored-by: Lior Rutenberg <[email protected]>
Co-authored-by: Matus Kysel <[email protected]>
Co-authored-by: Nikita Kryuchkov <[email protected]>
Co-authored-by: moshe-blox <[email protected]>
Co-authored-by: olegshmuelov <[email protected]>
Co-authored-by: MatheusFranco99 <[email protected]>
Co-authored-by: Anton Korpusenko <[email protected]>
Co-authored-by: Anton Korpusenko <[email protected]>
Co-authored-by: Gal Rogozinski <[email protected]>
Co-authored-by: Pavel Krolevets <[email protected]>
y0sher added a commit that referenced this pull request Jul 28, 2024
* fix: stale operator ID in `p2pNetwork` (#1229) (#1230)

* fix: stale operator ID in `p2pNetwork`

---------

Co-authored-by: Lior Rutenberg <[email protected]>

* v1.2.2 (#1248)

* fix: stale operator ID in `p2pNetwork` (#1229)

* fix: stale operator ID in `p2pNetwork`

---------

Co-authored-by: Lior Rutenberg <[email protected]>

* fix: sufficient timeout for initial duty fetch (#1214)

* fix: sufficient timeout for initial duty fetch (#1214)
---------

Co-authored-by: Matus Kysel <[email protected]>

* deployment: change bootnode for holesky-stage (#1233)

* deploy new bootnode ENR for holesky stage

* Voluntary exit (#1200)

* Voluntary exit

---------

Co-authored-by: moshe-blox <[email protected]>
Co-authored-by: olegshmuelov <[email protected]>
Co-authored-by: MatheusFranco99 <[email protected]>

* feat: include 'connected' in peer scores log (#1224)

* feat: include 'connected' in peer scores log

* P2P metrics  (#1163)

* metrics: added p4 score (invalidMessageDeliveries)

* metrics: added total msgs accepted, msgs accepted from peer with Id, signatures verification

* deploy to the stage

# Conflicts:
#	.gitlab-ci.yml

* metrics: added counters flush once in 8h

* metrics: added counters for duties

* Added auto delete disconnected peers label metrics. Added RSA verifications metric

* disabled ci

* Updated p4 score metric update

* metrics: added p4 score (invalidMessageDeliveries)

* metrics: added total msgs accepted, msgs accepted from peer with Id, signatures verification

* deploy to the stage

# Conflicts:
#	.gitlab-ci.yml

* metrics: added counters flush once in 8h

* metrics: added counters for duties

* Added auto delete disconnected peers label metrics. Added RSA verifications metric

* disabled ci

* Updated p4 score metric update

* review comments fixes

* deploy

* deploy

* testing metrics differ

* added duties created and finalized

* removed extra monitoring.metricsreporter usage

* removed topic from p4score. made it a sum of squares

* deploy to all nodes

* deploy p2p_metrics

* pr review fixes

* trigger ci

* deploy 9-20

* Fix msg validation rsa verification counter metric

* allocate p2p_metrics

* inspect scores more frequently, but don't log every time

* renamed duties created/finalized metrics and refactored to record role

* deploy to 5--8

* deploy to 5--8

* rename metric

* blank space

* approve spec change (just a metric)

* refactors

* reset scores

* metric help msg

* revert gitlab

* deploy

* revert deploy

* Add metrics for signature verifications

* Update differ.config.yaml with approved changes

---------

Co-authored-by: Anton Korpusenko <[email protected]>
Co-authored-by: Gal Rogozinski <[email protected]>
Co-authored-by: Matus Kysel <[email protected]>
Co-authored-by: MatheusFranco99 <[email protected]>
Co-authored-by: moshe-blox <[email protected]>

* Node health (#1203)

* chore: link to SSV API docs in configs & README

* initial commit

* add node health route to ssv API

* update health route

* update health route

* update health route

* update health route

* deploy to stage

* add plaintext response

* lint

* lint

* change to good/bad

* lint

* lint

* refactor

* Revert "deploy to stage"

This reverts commit 2f54f4e.

* lint

* add inbound/outbound count for health + deploy to stage

* change ports back

* update count

* lint

* update conns

* lint

* remove connected peer count

* test blocked ports

* Revert "remove connected peer count"

This reverts commit 79e2b94.

* leave only active peers count

* Revert "test blocked ports"

This reverts commit 6fc9282.

* ci to stage

* add mutex to nodes access

* refactor: node health API (#1222)

* refactor: node health API

* added cpu_cores to healthcheck output

* fix inbound/outbound stats

* Remove CPU core reporting

---------

Co-authored-by: moshe-blox <[email protected]>
Co-authored-by: Matus Kysel <[email protected]>
Co-authored-by: moshe-blox <[email protected]>

* feat: subscribe to a random subnet with 0 validators (#1245)

* feat: subscribe to a random subnet with 0 validators

* Fix: health route host addres (#1246)

* node health api route advertises the host addresses from the config.

* set up listenaddress directly

* feat: rate limit inbound connections by IP (#1226)

* feat: rate limit inbound connections by IP

* activate conngater

* deploy to 5--8

* fix

* fix

* Refactor connection gating in p2p setup

* Update ipLimiter parameters

* revert gitlab

* Revert "revert gitlab"

This reverts commit fcc7902.

* Revert "Revert "revert gitlab""

This reverts commit feb9e4e.

---------

Co-authored-by: Gal Rogozinski <[email protected]>

---------

Co-authored-by: moshe-blox <[email protected]>
Co-authored-by: Lior Rutenberg <[email protected]>
Co-authored-by: Matus Kysel <[email protected]>
Co-authored-by: Nikita Kryuchkov <[email protected]>
Co-authored-by: moshe-blox <[email protected]>
Co-authored-by: olegshmuelov <[email protected]>
Co-authored-by: MatheusFranco99 <[email protected]>
Co-authored-by: Anton Korpusenko <[email protected]>
Co-authored-by: Anton Korpusenko <[email protected]>
Co-authored-by: Gal Rogozinski <[email protected]>
Co-authored-by: Pavel Krolevets <[email protected]>

* Revert "v1.2.2 (#1248)" (#1263)

This reverts commit ff2f594.

* chore: fix some function names

Signed-off-by: linghuying <[email protected]>

---------

Signed-off-by: linghuying <[email protected]>
Co-authored-by: Lior Rutenberg <[email protected]>
Co-authored-by: moshe-blox <[email protected]>
Co-authored-by: rehs0y <[email protected]>
Co-authored-by: Matus Kysel <[email protected]>
Co-authored-by: Nikita Kryuchkov <[email protected]>
Co-authored-by: moshe-blox <[email protected]>
Co-authored-by: olegshmuelov <[email protected]>
Co-authored-by: MatheusFranco99 <[email protected]>
Co-authored-by: Anton Korpusenko <[email protected]>
Co-authored-by: Anton Korpusenko <[email protected]>
Co-authored-by: Gal Rogozinski <[email protected]>
Co-authored-by: Pavel Krolevets <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants