Share length validation #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GalRogozinski
added
Networking
9 tasks
GalRogozinski
approved these changes
Aug 15, 2024
y0sher
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Approving this but with an *.
- @GalRogozinski @MatheusFranco99
I think if this check is required maybe its time to think of separating the base for committee and other runners. Since other runners will never recv more than one share, it looks weird that their func signature can recv a map of shares.
|
@y0sher I agree. |
alan-ssvlabs
approved these changes
Aug 19, 2024
| ks := testingutils.KeySetMapForValidators(10) | ||
| shares := testingutils.ShareMapFromKeySetMap(ks) | ||
|
|
||
| // No errors since one share must be valid for all runners |
There was a problem hiding this comment.
Is this comment right for this test?
There was a problem hiding this comment.
Indeed not. Updating. Thanks for the catch!
|
|
||
| shares := map[phase0.ValidatorIndex]*types.Share{} | ||
|
|
||
| // No errors since one share must be valid for all runners |
There was a problem hiding this comment.
Updating, thanks!
GalRogozinski
pushed a commit
that referenced
this pull request
Sep 12, 2024
* Add share length validation in runner construction * Align to error handling in runners constructions * Add validation to committee runner * Add runner construction tests * Refactor runner construction in testingutil to deal with creation errors * Generate JSON tests * Fix lint issue * Fix comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a validation to the runners' construction function (except by
CommitteeRunner) to assert that theshareargument has only one entry (only one share).