feature: (alan) filter committee duties per slot validator duties #467
Conversation
…e duty for that slot.
y0sher
force-pushed
the
feature/filter-committee-duty-shares
branch
from
4411fff
to
940c8a3
Compare
ssv/committee.go
Outdated
| dutyShares := make(map[spec.ValidatorIndex]*types.Share) | ||
| for _, bduty := range duty.ValidatorDuties { | ||
| if _, exists := c.Share[bduty.ValidatorIndex]; !exists { | ||
| return fmt.Errorf("no share for validator %d", bduty.ValidatorIndex) |
There was a problem hiding this comment.
shouldn't this be continue simply?
are we sure we want to fail the run just because of one miss?
There was a problem hiding this comment.
Yes, from the spec perspective, I would also say continue is better. On the other hand, in ssv, it's strange that the operator doesn't the share for the duty since he requested the duty for this validator.
There was a problem hiding this comment.
@y0sher Approving, but it seems to me that continue makes more sense (for the above issue)
please change as you wish and merge when you're ready. |
|
@y0sher @GalRogozinski |
| ) | ||
|
|
||
| // SharesWithFractionOfDutyValidators performs a complete duty execution for a runner that only has a fraction of the shares for the duty's validators | ||
| func SharesWithFractionOfDutyValidators() tests.SpecTest { |
There was a problem hiding this comment.
Rename to MissingSomeShares
| dutyValidators := []int{1, 2, 3, 4, 5, 6, 7, 8, 9, 10} | ||
|
|
||
| multiSpecTest := &committee.MultiCommitteeSpecTest{ | ||
| Name: "shares with fraction of duty validators", |
There was a problem hiding this comment.
| Name: "shares with fraction of duty validators", | |
| Name: "start committee duty with missing shares", |
* Filter shares for slot `CommitteeRunner` based on validators that have duty for that slot. * Filter duty and create share map according to owned validators * Add test: start duty with no shares for duty's validators * Add test: happy flow for committee with fraction of duty's validators * Generate JSON tests * Apply suggestions --------- Co-authored-by: MatheusFranco99 <[email protected]>
Description
Committeestruct holds all the shares for the validators of that committee, though aCommitteeRunneronly lives for a certain slot and thereby only needs shares of validators that have duty for that slot.Changes
Filter the shares of
Committeeto create a subset that has only shares of validators that have duties for this slot.