Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop residue test #335

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Drop residue test #335

merged 1 commit into from
Feb 4, 2024

Conversation

MatheusFranco99
Copy link
Contributor

When I run make generate-jsons locally, it removes a JSON test file that seems to be a residue from old PRs.

@MatheusFranco99 MatheusFranco99 self-assigned this Jan 2, 2024
GalRogozinski
GalRogozinski reviewed Jan 3, 2024
View reviewed changes
Copy link
Contributor

@GalRogozinski GalRogozinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it this existing test:
qbft/spectest/tests/roundchange/valid_justification.go?

@MatheusFranco99
Copy link
Contributor Author

@GalRogozinski
Yeah. But notice that I removed its json in the ssv folder and not in qbft.
It's strange how it ended up there.

@GalRogozinski GalRogozinski merged commit 559e961 into main Feb 4, 2024
2 checks passed
@GalRogozinski GalRogozinski deleted the residue-test branch February 4, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0sher y0sher y0sher approved these changes

@MatusKysel MatusKysel MatusKysel approved these changes

@GalRogozinski GalRogozinski GalRogozinski approved these changes

Assignees

@MatheusFranco99 MatheusFranco99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MatheusFranco99 @y0sher @MatusKysel @GalRogozinski