Stop instances tests #297
Merged
Stop instances tests #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GalRogozinski
commented
Jul 30, 2023
| import "github.com/bloxapp/ssv-spec/qbft/spectest/tests" | ||
|
|
||
| // ForceStopPrevious tests stoping previous running instances when starting a new instance | ||
| func ForceStopPrevious() tests.SpecTest { |
There was a problem hiding this comment.
This is deleted because prev_decided and prev_not_decided cover this
GalRogozinski
requested review from
alonmuroch,
y0sher,
moshe-blox and
MatheusFranco99
MatheusFranco99
approved these changes
Aug 6, 2023
y0sher
approved these changes
Aug 6, 2023
alonmuroch
requested changes
Aug 7, 2023
alonmuroch
approved these changes
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #287
Also adds smart marshaling
instance.forceStopfield so it will only serialize to JSON on relevant tests.Adds smart marshaling
Heightfield torunInstanceData