Fallback to empty string as Rails 5.1 can't handle nil paths #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What kind of magic is this?! |
ssteeg-mdsol
force-pushed
the
fix/rails_5_1_workaround
branch
from
f8d6cb8 to
f8cb0e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rails 5.1 (specifically actionpack), there is an issue where passing an empty path to
Rails.application.routes.recognize_pathresults in aNoMethodError: undefined methodencoding' for nil:NilClass` exception being thrown.See: rails/rails@03925dc
I'm unsure why this issue did not occur prior to openzipkin#143 though. Seems like the same problem should occur, but doesn't 🤷♂️