Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks when using inline SVGs #13

Open
olliekav opened this issue Feb 15, 2015 · 4 comments
Open

Breaks when using inline SVGs #13

olliekav opened this issue Feb 15, 2015 · 4 comments
Assignees
Labels

Comments

@olliekav
Copy link

My portfolio site uses quite a few SVGs inline, this breaks with the error...

Uncaught Error: Namespace attributes are not supported. ReactJSX is not XML.

I can get away with removing the namespace on the actual SVG itself, but I'm using

<a xlink:href="/">

To create a linkable logo.

Any way around this? Love the script!

@ssorallen ssorallen added the bug label Feb 15, 2015
@ssorallen
Copy link
Owner

I will take a look at a workaround for this. It's an intentional limitation of JSX from what I have found, and so it's not a bug from their point of view.

Is your portfolio site public? I'd love to see how you're using TurboReact.

@ssorallen ssorallen self-assigned this Feb 16, 2015
@olliekav
Copy link
Author

Okay, thanks for having a look. Just ironing out a few last bugs then I'll
send you a link.
On 16 Feb 2015 09:46, "Ross Allen" [email protected] wrote:

I will take a look at a workaround for this. It's an intentional
limitation of JSX from what I have found, and so it's not a bug from their
point of view.

Is your portfolio site public? I'd love to see how you're using TurboReact.


Reply to this email directly or view it on GitHub
#13 (comment)
.

@ssorallen
Copy link
Owner

The React team is still considering how to properly handle SVGs: facebook/react#1657

It might make sense to have a workaround in Reactize until React lands full SVG support, and so I will keep looking. I also want to make Reactize fall back to a full page load if it has any problems converting documents.

@olliekav
Copy link
Author

Ok, no problem. I'll look at a work around for now. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants