Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification of Groupees to access DRM Free Game list directly via AJAX #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Nielk1
Copy link

@Nielk1 Nielk1 commented Mar 9, 2015

Hopefully this is proper as it's my first time using CoffeeScript or Pull Requests.

The AJAX here is synchronous, which is less than optimal, but I have 174 bundles and it takes only 3 seconds for me.
It's unclear to me how to handle a deferred return for asynchronous ajax with the given object structure.

EDIT: Fix for issue #3

Nielk1 added 2 commits March 8, 2015 23:31
… Games.

async:false was used so that might need a look over and reimplementation, but it works for now.
@ssokolow
Copy link
Owner

Thanks. I'll try to take a look at it within the week. I hope you don't mind that I edited your initial comment to produce a cross reference.

As for asynchronous operation, I honestly didn't consider AJAX when doing the initial design, so it's entirely possible that I'll need to rework it to achieve that.

@ssokolow
Copy link
Owner

Sorry for the lack of response. The last four days were a mess. (Two all-nighters to take care of more urgent stuff)

Given that I always try to give users an easy way to use only the server resources they need (eg. submitting from the GOG sale confirmation page to avoid dumping their entire collection on ITAD every time they submit), I'm a little loathe to make "load everything via an unpredictable number of AJAX requests the only option.

As such, I'm going to need a little time to rework the script to support multiple option per matching URL. As I'm familiar with the codebase, it shouldn't take too much work, but I'm still catching up on the mess that drove me to two all-nighters, so it could be another week before I get to it.

Again, sorry for the delay.

@ssokolow
Copy link
Owner

I just noticed that in-progress changes at GOG are completely preventing the script from seeing certain games, so that'll have to take priority.

@ssokolow
Copy link
Owner

ssokolow commented Apr 2, 2015

Ok, the script is mostly back in business with list-view importing everything perfectly but shelf view having a bit of trouble on some games still.

Once I've got that sorted out, I'll get back to this.

@ssokolow
Copy link
Owner

Still haven't fully sorted out the issues with unbundled GOG games but they just switched to a paginated view so it looks like now is a good time for me to settle on how to merge this at the same time as I rearchitect to have one true, proper way to handle "current page/all pages" for all scrapers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants