Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small cleanups of unused code #515

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Small cleanups of unused code #515

merged 1 commit into from
Nov 21, 2024

Conversation

ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Nov 6, 2024

Remove a FuncADL file left over from version 2 client, and a corresponding exception (@gordonwatts please check this isn't a problem for any of your code ...)

@ponyisi ponyisi requested a review from gordonwatts November 6, 2024 03:41
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.85%. Comparing base (7e20e9d) to head (d88afe6).
Report is 28 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
+ Coverage   83.90%   84.85%   +0.95%     
==========================================
  Files          26       25       -1     
  Lines        1485     1466      -19     
==========================================
- Hits         1246     1244       -2     
+ Misses        239      222      -17     
Flag Coverage Δ
unittests 84.85% <ø> (+0.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ponyisi ponyisi added this to the 3.0.2 bugfixes milestone Nov 17, 2024
Copy link
Collaborator

@gordonwatts gordonwatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@gordonwatts
Copy link
Collaborator

Changed to 3.0.1 because it is going in now

@ponyisi ponyisi merged commit c4c8562 into master Nov 21, 2024
42 checks passed
@ponyisi ponyisi deleted the remove_unused_code branch November 21, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants