Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require namespace in Rucio DIDs #513

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Nov 5, 2024

Resolves #31. RucioDatasetIdentifier will throw an exception if a namespace isn't specified.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.92%. Comparing base (226d3dc) to head (0947816).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #513      +/-   ##
==========================================
+ Coverage   83.90%   83.92%   +0.02%     
==========================================
  Files          26       26              
  Lines        1485     1487       +2     
==========================================
+ Hits         1246     1248       +2     
  Misses        239      239              
Flag Coverage Δ
unittests 83.92% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@BenGalewsky BenGalewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@BenGalewsky BenGalewsky merged commit b196f68 into master Nov 14, 2024
42 checks passed
@BenGalewsky BenGalewsky deleted the 31_rucio_require_namespace branch November 14, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require namespace in dataset
2 participants