Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of tokens near expiry #487

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Better handling of tokens near expiry #487

merged 4 commits into from
Oct 3, 2024

Conversation

ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Oct 2, 2024

Resolves #473:

  • if an auth token is within 60 seconds of expiry, renew it before proceeding with request;
  • if a transformation status query returns an auth error, attempt a retry with an updated token;
  • add better handling of other error codes when querying transformation status.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.29%. Comparing base (7e09033) to head (e776afb).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #487      +/-   ##
==========================================
+ Coverage   82.96%   84.29%   +1.32%     
==========================================
  Files          26       26              
  Lines        1403     1515     +112     
==========================================
+ Hits         1164     1277     +113     
+ Misses        239      238       -1     
Flag Coverage Δ
unittests 84.29% <100.00%> (+1.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ketan96-m ketan96-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@ponyisi ponyisi merged commit 53226cd into master Oct 3, 2024
36 checks passed
@ponyisi ponyisi deleted the 473_reauthenticate branch October 3, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long-running transforms can lose their authentication
2 participants