Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors from ServiceX that aren't JSON do not tell us much #61

Closed
gordonwatts opened this issue Jul 9, 2020 · 4 comments
Closed

Errors from ServiceX that aren't JSON do not tell us much #61

gordonwatts opened this issue Jul 9, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@gordonwatts
Copy link
Collaborator

As a user I want to be able to understand what errors are comming back from servicex when the service totally fails:

  • The request ID
  • If the response isn't in JSON, it would be good to have the HTML dumped instead.
@gordonwatts gordonwatts added the enhancement New feature or request label Jul 9, 2020
@gordonwatts gordonwatts self-assigned this Jul 9, 2020
@gordonwatts gordonwatts removed their assignment Jul 30, 2020
@AndrewEckart
Copy link
Contributor

AndrewEckart commented Aug 6, 2020

I like the example of the Twilio API here, i.e. we should use correct HTTP status codes and send back a JSON body containing additional information (I think we already do this in many cases). We shouldn't send back HTML if there is an error requesting an API resource.

The frontend client can then use conditional logic to raise an appropriate ServiceXException, passing on the message from the server.

@gordonwatts
Copy link
Collaborator Author

That would be fine - one would need to add a story to the servicex app that scans for all "exceptions" and make sure they come back properly.

@gordonwatts gordonwatts reopened this Aug 12, 2020
@gordonwatts gordonwatts self-assigned this Sep 26, 2020
@gordonwatts gordonwatts added this to the Examples And Use (2.2) milestone Nov 23, 2020
@gordonwatts gordonwatts removed their assignment Jul 25, 2021
@ponyisi
Copy link
Collaborator

ponyisi commented Nov 5, 2024

Essentially the same complaint as #502 (except we want the request ID too)

ponyisi added a commit that referenced this issue Nov 5, 2024
…ing Errors from ServiceX that aren't JSON do not tell us much #61)
BenGalewsky pushed a commit that referenced this issue Nov 14, 2024
…ing Errors from ServiceX that aren't JSON do not tell us much #61)
BenGalewsky pushed a commit that referenced this issue Nov 14, 2024
…ing Errors from ServiceX that aren't JSON do not tell us much #61)
@ponyisi
Copy link
Collaborator

ponyisi commented Nov 14, 2024

Resolved by #501

@ponyisi ponyisi closed this as completed Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants