-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose renderAheadOffset prop #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty! Could you please also update the file in example folder?
src/EmojiInput.js
Outdated
@@ -643,7 +643,9 @@ EmojiInput.defaultProps = { | |||
emojiFontSize: 40, | |||
categoryFontSize: 20, | |||
resetSearch: false, | |||
filterFunctions: [] | |||
filterFunctions: [], | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove empty line
Added to example folder and also tried to improve its description in the readme at little bit, referencing the original issue #36 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing!
Relate to any issue?
#36
Breaking change?
Nope
What this PR does?
Exposes
renderAheadOffset
prop so that people can decide for themselves which side of performance they would like to optimize. See #36