Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose renderAheadOffset prop #37

Merged
merged 2 commits into from
May 11, 2019
Merged

Expose renderAheadOffset prop #37

merged 2 commits into from
May 11, 2019

Conversation

gutosanches
Copy link
Contributor

Relate to any issue?

#36

Breaking change?

Nope

What this PR does?

Exposes renderAheadOffset prop so that people can decide for themselves which side of performance they would like to optimize. See #36

Copy link
Collaborator

@rijn rijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty! Could you please also update the file in example folder?

@@ -643,7 +643,9 @@ EmojiInput.defaultProps = {
emojiFontSize: 40,
categoryFontSize: 20,
resetSearch: false,
filterFunctions: []
filterFunctions: [],

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove empty line

@gutosanches
Copy link
Contributor Author

gutosanches commented May 9, 2019

Added to example folder and also tried to improve its description in the readme at little bit, referencing the original issue #36

Copy link
Collaborator

@rijn rijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Approved.

Copy link
Owner

@sskhandek sskhandek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

@sskhandek sskhandek merged commit ddc5834 into sskhandek:master May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants