fix: make casing consistent #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #193 +/- ##
==========================================
- Coverage 42.31% 41.91% -0.41%
==========================================
Files 67 67
Lines 813 816 +3
Branches 143 144 +1
==========================================
- Hits 344 342 -2
- Misses 469 474 +5 ☔ View full report in Codecov by Sentry. |
ssilve1989
force-pushed
the
fix/consistent-casing
branch
from
0e3915d
to
4dde71f
Compare
ssilve1989
added a commit
that referenced
this pull request
Mar 31, 2024
special formatting for display purposes should be left to the google sheet ops not any other place. Every other place such as - firestore - command queries should be consistently lowercase. #179 introduced a regression since lookup commands were trying to match on lowercase but data was being stored as capital case
ssilve1989
added a commit
that referenced
this pull request
Mar 31, 2024
🤖 I have created a release *beep* *boop* --- ## [1.2.8](v1.2.7...v1.2.8) (2024-03-31) ### Bug Fixes * make casing consistent ([#193](#193)) ([1a5478f](1a5478f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
special formatting for display purposes should be left to the google sheet ops not any other place. Every other place such as
#179 introduced a regression since lookup commands were trying to match on lowercase but data was being stored as capital case