Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added schema support for SQLite connections #67

Merged
merged 22 commits into from
Nov 27, 2023
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
42f7401
feat: Added schema support for SQLite connections
Nov 8, 2023
459c6bf
chore: Require dbplyr >= 2.4.0
Nov 13, 2023
b138653
fix(test-update_snapshot): Specify df argument in `dplyr::copy_to`
Nov 13, 2023
1f681d0
chore: linting
Nov 13, 2023
a30472d
chore: Add entry to NEWS.md
Nov 13, 2023
139ef5b
feat(sqlite_schema): Rework `get_schema` and `table_exists` to S3 met…
Nov 21, 2023
708fb2c
fix(sqlite_schema): Exclude temporary SQLite tables from `get_tables`
Nov 21, 2023
605861c
feat: Allow `id` to fallback to table name with "."
Nov 21, 2023
bd0691c
fix(get_tables): Correctly handle temporary tables in SQLite
Nov 21, 2023
a795376
fix(table_exists): Add bindings and unite man pages
Nov 21, 2023
0ab9874
chore: Conditionally skip example parts
Nov 21, 2023
7333856
chore: Linting
Nov 21, 2023
0f11308
fix(table_exists): Remove undesirable conversion to `DBI::Id`
Nov 21, 2023
e9a4e04
test(table_exists): Rework ambiguity test for SQLite
Nov 21, 2023
751b412
fix: Correctly handle missing schema in `table_exists.SQLiteConnection`
Nov 21, 2023
96167d9
fix(table_exists.SQLiteConnection): Prepare `db_table_id` for loose(r…
Nov 21, 2023
9c6997a
chore: Remove redundant logic in examples
Nov 23, 2023
e61090c
chore: Add `get_schema.tbl_dbi` and `get_schema.Id`
Nov 23, 2023
6c8ef73
fix: Subset `exact_match` instead of `tables`
Nov 23, 2023
da2888b
test: Add test for `allow_table_only`
Nov 23, 2023
93c9655
test(id): re-added test for `id` on `DBIConnection`s
Nov 23, 2023
071a224
docs: Fix `create_logs_if_missing` example failing check
Nov 23, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(get_tables): Correctly handle temporary tables in SQLite
Marcus Munch Grünewald authored and Marcus Munch Grünewald committed Nov 21, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit bd0691cab7e4daab56e9022544fa9c36004f3fb1
2 changes: 1 addition & 1 deletion R/get_table.R
Original file line number Diff line number Diff line change
@@ -97,7 +97,7 @@ get_tables.SQLiteConnection <- function(conn, pattern = NULL) {
}

tables <- DBI::dbGetQuery(conn, query) |>
dplyr::mutate(dplyr::across("schema", ~ ifelse(. == "main", NA_character_, .)))
dplyr::mutate(dplyr::across("schema", ~ ifelse(. %in% c("temp", "main"), NA_character_, .)))

if (nrow(tables) == 0) warning("No tables found. Check user privileges / database configuration")