Fix netconf framing protocol #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver capabilities This fixes an issue where the NetConfSession would expect the framing protocol to be used if ServerCapabilities contained 1.1, however the server would actually be using the legacy protocol as the client only advertises support for 1.0.
…ing_protocol Adding co-author credit from sshnet#639: Co-authored-by: Jason Larke <[email protected]>
|
It appears that at least for Cisco WLCs, the implementation of the framing protocol is indeed broken. I need to hardcode @WojciechNagorski Please merge this PR. |
Rob-Hague
approved these changes
Jun 16, 2024
|
I took #639 and the remaining comments from this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The implementation was not compliant to the RFC6242. Although the client does NOT support the framing protocol, if the server reported that is did, the client would still try to using the framing protocol. The result is that client and server are unable to communicate at the RPC XML layer and the session times out.
Solution
The solution is to simply never used framing protocol regardless of whether the server does or not.
Additional Minor Changes
Experimental Release for .NET Standard 2.1
https://github.com/schaveyt/SSH.NET/releases/tag/2021.04.02