Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix netconf framing protocol #946

Merged
merged 9 commits into from
Jun 16, 2024

Conversation

schaveyt
Copy link
Contributor

@schaveyt schaveyt commented Apr 3, 2022

Problem

The implementation was not compliant to the RFC6242. Although the client does NOT support the framing protocol, if the server reported that is did, the client would still try to using the framing protocol. The result is that client and server are unable to communicate at the RPC XML layer and the session times out.

Solution

The solution is to simply never used framing protocol regardless of whether the server does or not.

Additional Minor Changes

  1. Address null pointer exception when the netconf_session is disposing.
  2. Add an example of the RPC XML to use when transmitting calls.

Experimental Release for .NET Standard 2.1

https://github.com/schaveyt/SSH.NET/releases/tag/2021.04.02

Jason Larke and others added 4 commits March 10, 2020 12:02
…ver capabilities

This fixes an issue where the NetConfSession would expect the
framing protocol to be used if ServerCapabilities contained 1.1,
however the server would actually be using the legacy protocol as
the client only advertises support for 1.0.
…ing_protocol

Adding co-author credit from sshnet#639:

Co-authored-by: Jason Larke <[email protected]>
@Rob-Hague
Copy link
Collaborator

I think we should take this one on good faith. I have no knowledge of netconf and we have no testing but it seems reasonable to me, and with #639 and #1197 there are at least 3 people for whom it works.

@ddombrowsky
Copy link

ddombrowsky commented Jun 13, 2024

It appears that at least for Cisco WLCs, the implementation of the framing protocol is indeed broken. I need to hardcode _usingFramingProtocol = false; to get SendReceiveRpc to do anything but timeout.

@WojciechNagorski Please merge this PR.

@Rob-Hague Rob-Hague self-requested a review as a code owner June 16, 2024 09:40
@Rob-Hague Rob-Hague merged commit 6933e09 into sshnet:develop Jun 16, 2024
1 check was pending
@Rob-Hague
Copy link
Collaborator

I took #639 and the remaining comments from this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants