Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support creating Shell(Stream) without PTY #1419

Merged
merged 17 commits into from
Jun 16, 2024
Merged

Support creating Shell(Stream) without PTY #1419

merged 17 commits into from
Jun 16, 2024

Conversation

scott-xu
Copy link
Collaborator

Fixes #1418

@scott-xu scott-xu marked this pull request as ready for review May 31, 2024 03:08
Rob-Hague
Rob-Hague reviewed Jun 9, 2024
View reviewed changes
Copy link
Collaborator

@Rob-Hague Rob-Hague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure just yet whether the behaviour should be differentiated from the default by more than just an overload, i.e. whether they should be methods with different names e.g. CreateShellNoTerminal

src/Renci.SshNet/ShellStream.cs Show resolved Hide resolved
src/Renci.SshNet/ShellStream.cs Outdated Show resolved Hide resolved
src/Renci.SshNet/SshClient.cs Outdated Show resolved Hide resolved
src/Renci.SshNet/SshClient.cs Outdated Show resolved Hide resolved
src/Renci.SshNet/SshClient.cs Outdated Show resolved Hide resolved
test/Renci.SshNet.IntegrationTests/SshTests.cs Outdated Show resolved Hide resolved
test/Renci.SshNet.IntegrationTests/SshTests_TTYDisabled.cs Outdated Show resolved Hide resolved
test/Renci.SshNet.IntegrationTests/SshTests.cs Outdated Show resolved Hide resolved
@scott-xu scott-xu marked this pull request as draft June 10, 2024 11:01
@scott-xu scott-xu marked this pull request as ready for review June 13, 2024 14:13
Rob-Hague
Rob-Hague approved these changes Jun 16, 2024
View reviewed changes
Copy link
Collaborator

@Rob-Hague Rob-Hague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Rob-Hague Rob-Hague merged commit 9dc7db9 into sshnet:develop Jun 16, 2024
1 check was pending
@scott-xu scott-xu deleted the support-disabling-pty branch July 20, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rob-Hague Rob-Hague Rob-Hague approved these changes

@drieseng drieseng Awaiting requested review from drieseng drieseng is a code owner

@WojciechNagorski WojciechNagorski Awaiting requested review from WojciechNagorski WojciechNagorski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support creating shell without PTY
2 participants
@scott-xu @Rob-Hague