Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an AOT compatibility test app #1378

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Conversation

Rob-Hague
Copy link
Collaborator

@Rob-Hague Rob-Hague commented Apr 18, 2024

Following the guides at
https://learn.microsoft.com/en-us/dotnet/core/deploying/trimming/prepare-libraries-for-trimming?pivots=dotnet-8-0
and https://devblogs.microsoft.com/dotnet/creating-aot-compatible-libraries/,
add an application which is published for AOT in CI.

This process fully verifies all code-paths in the library and its dependencies
for trimming/AOT, which the analyzers are not themselves able to do.

(As a side benefit, now we are also checking the library builds in Release)

closes #934

Following the guides at
https://learn.microsoft.com/en-us/dotnet/core/deploying/trimming/prepare-libraries-for-trimming?pivots=dotnet-8-0
and https://devblogs.microsoft.com/dotnet/creating-aot-compatible-libraries/,
add an application which is published for AOT in CI.

This process fully verifies all code-paths in the library and its dependencies
for trimming/AOT, which the analyzers are not themselves able to do.

(As a side benefit, now we are also checking the library builds in Release)
@Rob-Hague
Copy link
Collaborator Author

It correctly fails at the build (publish) step: https://ci.appveyor.com/project/drieseng/ssh-net/builds/49646532

@Rob-Hague Rob-Hague marked this pull request as ready for review April 19, 2024 06:36
@WojciechNagorski WojciechNagorski merged commit 71423c1 into sshnet:develop Apr 19, 2024
1 check passed
@Rob-Hague Rob-Hague deleted the aot branch April 19, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for NativeAOT
2 participants