Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old features [Part 1] #1117

Merged
merged 23 commits into from
May 9, 2023
Merged

Remove old features [Part 1] #1117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
63890ff
Use always FEATURE_REGEX_COMPILE
WojciechNagorski May 8, 2023
c24c4f5
Remove FEATURE_STRINGBUILDER_CLEAR
WojciechNagorski May 8, 2023
d01d47c
Remove FEATURE_HASHALGORITHM_DISPOSE
WojciechNagorski May 8, 2023
7939c7e
Remove FEATURE_ENCODING_ASCII
WojciechNagorski May 8, 2023
7cb38a5
Remove FEATURE_DIAGNOSTICS_TRACESOURCE
WojciechNagorski May 8, 2023
4999b11
Remove FEATURE_MEMORYSTREAM_GETBUFFER and FEATURE_MEMORYSTREAM_TRYGET…
WojciechNagorski May 8, 2023
4e5af00
Remove FEATURE_RNG_CREATE
WojciechNagorski May 8, 2023
aed2db9
Remove FEATURE_SOCKET_POLL and FEATURE_SOCKET_SELECT
WojciechNagorski May 8, 2023
bd58ddc
Remove FEATURE_SOCKET_DISPOSE
WojciechNagorski May 8, 2023
0e870e5
Remove FEATURE_TAP
WojciechNagorski May 8, 2023
e81d374
fix build
WojciechNagorski May 8, 2023
148a0b9
Remove FEATURE_ECDSA
WojciechNagorski May 8, 2023
d1d77eb
Remove FEATURE_HASH_MD5
WojciechNagorski May 8, 2023
a3a0733
Remove FEATURE_HASH_SHA1_CREATE
WojciechNagorski May 8, 2023
5648960
Remove FEATURE_HASH_SHA256_CREATE and FEATURE_HASH_SHA384_CREATE and …
WojciechNagorski May 8, 2023
9a1f675
Remove FEATURE_HMAC_*
WojciechNagorski May 8, 2023
6fa98bb
Remove FEATURE_WAITHANDLE_DISPOSE
WojciechNagorski May 8, 2023
1b6977e
Remove FEATURE_THREAD_THREADPOOL
WojciechNagorski May 8, 2023
60aacc3
Remove FEATURE_THREAD_COUNTDOWNEVENT
WojciechNagorski May 8, 2023
c685b6e
Remove FEATURE_THREAD_SLEEP and FEATURE_THREAD_TAP
WojciechNagorski May 8, 2023
f7782be
Remove FEATURE_STREAM_APM and FEATURE_STREAM_TAP
WojciechNagorski May 8, 2023
8f18f85
Remove FEATURE_SOCKET_EAP
WojciechNagorski May 8, 2023
b89644e
Remove FEATURE_REFLECTION_TYPEINFO
WojciechNagorski May 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ...sts/Classes/Channels/ChannelDirectTcpipTest_Dispose_SessionIsConnectedAndChannelIsOpen.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@
using System.Threading;
using Microsoft.VisualStudio.TestTools.UnitTesting;
using Moq;
#if !FEATURE_SOCKET_DISPOSE
using Renci.SshNet.Common;
#endif // !FEATURE_SOCKET_DISPOSE
using Renci.SshNet.Channels;
using Renci.SshNet.Messages.Connection;
using Renci.SshNet.Tests.Common;
Expand Down
3 changes: 0 additions & 3 deletions src/Renci.SshNet.Tests/Classes/Common/CountdownEventTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
using System.Diagnostics;
using System.Threading;
using Microsoft.VisualStudio.TestTools.UnitTesting;
#if !FEATURE_THREAD_COUNTDOWNEVENT
using CountdownEvent = Renci.SshNet.Common.CountdownEvent;
#endif

namespace Renci.SshNet.Tests.Classes.Common
{
Expand Down
4 changes: 0 additions & 4 deletions src/Renci.SshNet.Tests/Classes/Common/CountdownEventTest_Dispose_NotSet.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
using System;
using Microsoft.VisualStudio.TestTools.UnitTesting;
#if !FEATURE_THREAD_COUNTDOWNEVENT
using CountdownEvent = Renci.SshNet.Common.CountdownEvent;
#else
using System.Threading;
#endif

namespace Renci.SshNet.Tests.Classes.Common
{
Expand Down
4 changes: 0 additions & 4 deletions src/Renci.SshNet.Tests/Classes/Common/CountdownEventTest_Dispose_Set.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
using System;
using Microsoft.VisualStudio.TestTools.UnitTesting;
#if !FEATURE_THREAD_COUNTDOWNEVENT
using CountdownEvent = Renci.SshNet.Common.CountdownEvent;
#else
using System.Threading;
#endif

namespace Renci.SshNet.Tests.Classes.Common
{
Expand Down
4 changes: 1 addition & 3 deletions src/Renci.SshNet.Tests/Classes/Sftp/SftpFileStreamAsyncTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if FEATURE_TAP
using System;
using System;
using System.Threading.Tasks;
using Microsoft.VisualStudio.TestTools.UnitTesting;
using Moq;
Expand Down Expand Up @@ -66,4 +65,3 @@ protected byte[] GenerateRandom(uint length, Random random)
}
}
}
#endif
4 changes: 1 addition & 3 deletions src/Renci.SshNet.Tests/Classes/Sftp/SftpFileStreamTest_OpenAsync_FileAccessInvalid.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if FEATURE_TAP
using System;
using System;
using System.IO;
using System.Threading.Tasks;
using Microsoft.VisualStudio.TestTools.UnitTesting;
Expand Down Expand Up @@ -54,4 +53,3 @@ public void CtorShouldHaveThrownArgumentException()
}
}
}
#endif
4 changes: 1 addition & 3 deletions ...i.SshNet.Tests/Classes/Sftp/SftpFileStreamTest_OpenAsync_FileModeAppend_FileAccessRead.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if FEATURE_TAP
using System;
using System;
using System.IO;
using System.Threading.Tasks;
using Microsoft.VisualStudio.TestTools.UnitTesting;
Expand Down Expand Up @@ -55,4 +54,3 @@ public void CtorShouldHaveThrownArgumentException()
}
}
}
#endif
4 changes: 1 addition & 3 deletions ...Net.Tests/Classes/Sftp/SftpFileStreamTest_OpenAsync_FileModeAppend_FileAccessReadWrite.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if FEATURE_TAP
using System;
using System;
using System.IO;
using System.Threading.Tasks;
using Microsoft.VisualStudio.TestTools.UnitTesting;
Expand Down Expand Up @@ -55,4 +54,3 @@ public void CtorShouldHaveThrownArgumentException()
}
}
}
#endif
4 changes: 1 addition & 3 deletions ....SshNet.Tests/Classes/Sftp/SftpFileStreamTest_OpenAsync_FileModeAppend_FileAccessWrite.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if FEATURE_TAP
using System;
using System;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
Expand Down Expand Up @@ -152,4 +151,3 @@ public void RequestFStatOnSftpSessionShouldBeInvokedOnce()
}
}
}
#endif
4 changes: 1 addition & 3 deletions ...shNet.Tests/Classes/Sftp/SftpFileStreamTest_OpenAsync_FileModeCreateNew_FileAccessRead.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if FEATURE_TAP
using System;
using System;
using System.IO;
using System.Threading.Tasks;
using Microsoft.VisualStudio.TestTools.UnitTesting;
Expand Down Expand Up @@ -55,4 +54,3 @@ public void CtorShouldHaveThrownArgumentException()
}
}
}
#endif
4 changes: 1 addition & 3 deletions ....Tests/Classes/Sftp/SftpFileStreamTest_OpenAsync_FileModeCreateNew_FileAccessReadWrite.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if FEATURE_TAP
using System;
using System;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
Expand Down Expand Up @@ -133,4 +132,3 @@ public void RequestOpenOnSftpSessionShouldBeInvokedOnce()
}
}
}
#endif
4 changes: 1 addition & 3 deletions ...hNet.Tests/Classes/Sftp/SftpFileStreamTest_OpenAsync_FileModeCreateNew_FileAccessWrite.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if FEATURE_TAP
using System;
using System;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
Expand Down Expand Up @@ -133,4 +132,3 @@ public void RequestOpenOnSftpSessionShouldBeInvokedOnce()
}
}
}
#endif
4 changes: 1 addition & 3 deletions ...i.SshNet.Tests/Classes/Sftp/SftpFileStreamTest_OpenAsync_FileModeCreate_FileAccessRead.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if FEATURE_TAP
using System;
using System;
using System.IO;
using System.Threading.Tasks;
using Microsoft.VisualStudio.TestTools.UnitTesting;
Expand Down Expand Up @@ -55,4 +54,3 @@ public void CtorShouldHaveThrownArgumentException()
}
}
}
#endif
4 changes: 1 addition & 3 deletions .../Sftp/SftpFileStreamTest_OpenAsync_FileModeCreate_FileAccessReadWrite_FileDoesNotExist.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if FEATURE_TAP
using System;
using System;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
Expand Down Expand Up @@ -133,4 +132,3 @@ public void RequestOpenOnSftpSessionShouldBeInvokedOnce()
}
}
}
#endif
4 changes: 1 addition & 3 deletions ...lasses/Sftp/SftpFileStreamTest_OpenAsync_FileModeCreate_FileAccessReadWrite_FileExists.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if FEATURE_TAP
using System;
using System;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
Expand Down Expand Up @@ -133,4 +132,3 @@ public void RequestOpenOnSftpSessionShouldBeInvokedOnce()
}
}
}
#endif
6 changes: 2 additions & 4 deletions ...sses/Sftp/SftpFileStreamTest_OpenAsync_FileModeCreate_FileAccessWrite_FileDoesNotExist.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if FEATURE_TAP
using System;
using System;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
Expand Down Expand Up @@ -132,5 +131,4 @@ public void RequestOpenOnSftpSessionShouldBeInvokedOnceWithTruncateAndOnceWithCr
SftpSessionMock.Verify(p => p.RequestOpenAsync(_path, Flags.Write | Flags.CreateNewOrOpen | Flags.Truncate, _cancellationToken), Times.Once);
}
}
}
#endif
}
6 changes: 2 additions & 4 deletions ...ts/Classes/Sftp/SftpFileStreamTest_OpenAsync_FileModeCreate_FileAccessWrite_FileExists.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if FEATURE_TAP
using System;
using System;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
Expand Down Expand Up @@ -132,5 +131,4 @@ public void RequestOpenOnSftpSessionShouldBeInvokedOnce()
SftpSessionMock.Verify(p => p.RequestOpenAsync(_path, Flags.Write | Flags.CreateNewOrOpen | Flags.Truncate, _cancellationToken), Times.Once);
}
}
}
#endif
}
4 changes: 1 addition & 3 deletions src/Renci.SshNet.Tests/Classes/Sftp/SftpFileStreamTest_OpenAsync_FileModeInvalid.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if FEATURE_TAP
using System;
using System;
using System.IO;
using System.Threading.Tasks;
using Microsoft.VisualStudio.TestTools.UnitTesting;
Expand Down Expand Up @@ -54,4 +53,3 @@ public void CtorShouldHaveThrownArgumentException()
}
}
}
#endif
6 changes: 2 additions & 4 deletions ...et.Tests/Classes/Sftp/SftpFileStreamTest_OpenAsync_FileModeOpenOrCreate_FileAccessRead.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if FEATURE_TAP
using System;
using System;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
Expand Down Expand Up @@ -137,5 +136,4 @@ public void RequestOpenOnSftpSessionShouldBeInvokedOnce()
SftpSessionMock.Verify(p => p.RequestOpenAsync(_path, Flags.Read | Flags.CreateNewOrOpen, _cancellationToken), Times.Once);
}
}
}
#endif
}
4 changes: 1 addition & 3 deletions ...sts/Classes/Sftp/SftpFileStreamTest_OpenAsync_FileModeOpenOrCreate_FileAccessReadWrite.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if FEATURE_TAP
using System;
using System;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
Expand Down Expand Up @@ -133,4 +132,3 @@ public void RequestOpenOnSftpSessionShouldBeInvokedOnce()
}
}
}
#endif
4 changes: 1 addition & 3 deletions ...t.Tests/Classes/Sftp/SftpFileStreamTest_OpenAsync_FileModeOpenOrCreate_FileAccessWrite.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if FEATURE_TAP
using System;
using System;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
Expand Down Expand Up @@ -133,4 +132,3 @@ public void RequestOpenOnSftpSessionShouldBeInvokedOnce()
}
}
}
#endif
4 changes: 1 addition & 3 deletions ...nci.SshNet.Tests/Classes/Sftp/SftpFileStreamTest_OpenAsync_FileModeOpen_FileAccessRead.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if FEATURE_TAP
using System;
using System;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
Expand Down Expand Up @@ -139,4 +138,3 @@ public void RequestOpenOnSftpSessionShouldBeInvokedOnce()
}
}
}
#endif
4 changes: 1 addition & 3 deletions ...shNet.Tests/Classes/Sftp/SftpFileStreamTest_OpenAsync_FileModeOpen_FileAccessReadWrite.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if FEATURE_TAP
using System;
using System;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
Expand Down Expand Up @@ -133,4 +132,3 @@ public void RequestOpenOnSftpSessionShouldBeInvokedOnce()
}
}
}
#endif
4 changes: 1 addition & 3 deletions ...ci.SshNet.Tests/Classes/Sftp/SftpFileStreamTest_OpenAsync_FileModeOpen_FileAccessWrite.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if FEATURE_TAP
using System;
using System;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
Expand Down Expand Up @@ -133,4 +132,3 @@ public void RequestOpenOnSftpSessionShouldBeInvokedOnce()
}
}
}
#endif
4 changes: 1 addition & 3 deletions ...SshNet.Tests/Classes/Sftp/SftpFileStreamTest_OpenAsync_FileModeTruncate_FileAccessRead.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if FEATURE_TAP
using System;
using System;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
Expand Down Expand Up @@ -56,4 +55,3 @@ public void CtorShouldHaveThrownArgumentException()
}
}
}
#endif
4 changes: 1 addition & 3 deletions ...t.Tests/Classes/Sftp/SftpFileStreamTest_OpenAsync_FileModeTruncate_FileAccessReadWrite.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if FEATURE_TAP
using System;
using System;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
Expand Down Expand Up @@ -133,4 +132,3 @@ public void RequestOpenOnSftpSessionShouldBeInvokedOnce()
}
}
}
#endif
6 changes: 2 additions & 4 deletions ...shNet.Tests/Classes/Sftp/SftpFileStreamTest_OpenAsync_FileModeTruncate_FileAccessWrite.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if FEATURE_TAP
using System;
using System;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
Expand Down Expand Up @@ -132,5 +131,4 @@ public void RequestOpenOnSftpSessionShouldBeInvokedOnce()
SftpSessionMock.Verify(p => p.RequestOpenAsync(_path, Flags.Write | Flags.Truncate, _cancellationToken), Times.Once);
}
}
}
#endif
}
6 changes: 2 additions & 4 deletions ...c_ReadMode_NoDataInReaderBufferAndReadLessBytesFromServerThanCountAndEqualToBufferSize.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if FEATURE_TAP
using System;
using System;
using System.IO;
using System.Threading.Tasks;
using Microsoft.VisualStudio.TestTools.UnitTesting;
Expand Down Expand Up @@ -155,5 +154,4 @@ public async Task ReadShouldReturnAllRemaningBytesFromReadBufferAndReadAgainWhen
SftpSessionMock.Verify(p => p.RequestReadAsync(_handle, (ulong)(_serverData1Length + _serverData2Length), _readBufferSize, default));
}
}
}
#endif
}
4 changes: 1 addition & 3 deletions ..._ReadMode_NoDataInReaderBufferAndReadLessBytesFromServerThanCountAndLessThanBufferSize.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if FEATURE_TAP
using System;
using System;
using System.IO;
using System.Threading.Tasks;
using Microsoft.VisualStudio.TestTools.UnitTesting;
Expand Down Expand Up @@ -149,4 +148,3 @@ public async Task SubsequentReadShouldReadAgainFromCurrentPositionFromServerAndN
}
}
}
#endif
4 changes: 1 addition & 3 deletions ...eStreamTest_ReadAsync_ReadMode_NoDataInReaderBufferAndReadMoreBytesFromServerThanCount.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if FEATURE_TAP
using System;
using System;
using System.IO;
using Microsoft.VisualStudio.TestTools.UnitTesting;
using Moq;
Expand Down Expand Up @@ -140,4 +139,3 @@ public async Task SubsequentReadShouldReturnAllRemaningBytesFromReadBufferAndRea
}
}
}
#endif
Loading