Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do release workflow on tagged commit #103

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

lkeegan
Copy link
Member

@lkeegan lkeegan commented Jun 3, 2024

  • make release process atomic
    • github release is automatically made after successful build & PyPI upload
    • if the build fails then no release is made
  • allows new releases to be made from the command line

- make release process atomic
  - github release is automatically made after successful build & PyPI upload
  - if the build fails then no release is made
- allows new releases to be made from the command line
@lkeegan lkeegan force-pushed the do_release_on_tagged_commit branch from ff3b408 to 430a6eb Compare June 3, 2024 11:46
@lkeegan lkeegan requested a review from dokempf June 3, 2024 11:49
Copy link
Member

@dokempf dokempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like the atomicity, the process has always been disturbing me.

@dokempf dokempf merged commit c0e728d into main Jun 4, 2024
@dokempf dokempf deleted the do_release_on_tagged_commit branch June 4, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants