Fix error when turning visual debugging on/off in Unity 5.4 or newer #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Unity 5.4, Unity added the Obsolete attribute to the WP8 and BlackBerry values in the UnityEditor.BuildTargetGroup enum and removed them as valid build targets for scripting defines.
This means that when you try and change the toggle value for the Enable Visual Debugging setting, you get the following 2 errors in the console:
PlayerSettings Validation: Requested build target group (15) doesn't exist; #define symbols for scripting won't be added.PlayerSettings Validation: Requested build target group (16) doesn't exist; #define symbols for scripting won't be added.This PR fixes these errors by checking each BuildTargetGroup enum value for the Obsolete attribute before trying to set any scripting defines.