Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[General:]Pool vs Context #99

Closed
sschmid opened this issue Mar 31, 2016 · 10 comments
Closed

[General:]Pool vs Context #99

sschmid opened this issue Mar 31, 2016 · 10 comments
Assignees
Labels
Milestone

Comments

@sschmid
Copy link
Owner

sschmid commented Mar 31, 2016

Hey guys, this is more or less a poll:
What do you guys actually think of the name Pool? I was thinking calling it Context instead of Pool. I started thinking that it might be a better name since we often use it to spilt our games into different 'contexts' like Core, Meta, UI

Let me know what you think, maybe you have even better suggestions...

@JuDelCo
Copy link

JuDelCo commented Mar 31, 2016

Pool is more short to write.

Yes, i'm very lazy

@grygus
Copy link

grygus commented Mar 31, 2016

I also prefer Pool, i think it's more sexy, like eye candy :)

@SvDvorak
Copy link

Pools makes me think of object pools which in one way is fitting because it refers to a pool of objects but at the same time it doesn't fit the Object Pool-pattern itself since we're querying and actually using the pool contents directly. Then again, pool is shorter to write as @JuDelCo mentioned =)

@JamesMcMahon
Copy link
Contributor

Yeah maybe I am just used to it, but I like the terminology Pool. It is a nice description of what it is and I think Context would actually be less clear.

Also JuDelCo is right about it being shorter 🍺

@Fijit
Copy link

Fijit commented Apr 2, 2016

I also prefer Pool for pretty much the same reasons @JamesMcMahon has already stated. I've used it for years and know what it means as I glance over code.

It also doesn't compete for auto-completion space unlike Context (ContextMenu in UnityEngine for example) - A feeble argument but I needed to add something unique to the poll ;-)

@sschmid
Copy link
Owner Author

sschmid commented Apr 3, 2016

Seems like you guys are outvoting me :)

@JamesMcMahon
Copy link
Contributor

It's your project Simon so ultimately it's your call. But I will say from experience that sometimes you can stare at a project so long that you see flaws where there are none. 😄

@sschmid sschmid added rfc and removed question labels Apr 15, 2016
@carlos-avila
Copy link

carlos-avila commented May 8, 2016

What about "Group"? 😉

@sschmid
Copy link
Owner Author

sschmid commented May 20, 2016

Thanks for your input and opinions. Pool will stay Pool :)
For now... 😈

@sschmid sschmid closed this as completed May 20, 2016
@sschmid sschmid reopened this Jan 6, 2017
@sschmid
Copy link
Owner Author

sschmid commented Jan 6, 2017

Old ghosts being reawakened. After experiencing confusion when talking about object pools and Entitas pools and after writing explanations like "a pool is basically a context" I finally decided to rename Pool to Context  😱

@sschmid sschmid added this to the 0.36.0 milestone Jan 6, 2017
@sschmid sschmid self-assigned this Jan 6, 2017
@ghost ghost added needs review and removed in progress labels Jan 9, 2017
@ghost ghost removed the needs review label Jan 9, 2017
sschmid added a commit that referenced this issue Jan 9, 2017
@sschmid sschmid changed the title Pool vs Context [General:]Pool vs Context Jan 9, 2017
@sschmid sschmid added this to Entitas Jul 2, 2023
@github-project-automation github-project-automation bot moved this to Todo in Entitas Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

7 participants