-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[General:]Pool vs Context #99
Comments
Pool is more short to write. Yes, i'm very lazy |
I also prefer Pool, i think it's more sexy, like eye candy :) |
Pools makes me think of object pools which in one way is fitting because it refers to a pool of objects but at the same time it doesn't fit the Object Pool-pattern itself since we're querying and actually using the pool contents directly. Then again, pool is shorter to write as @JuDelCo mentioned =) |
Yeah maybe I am just used to it, but I like the terminology Pool. It is a nice description of what it is and I think Context would actually be less clear. Also JuDelCo is right about it being shorter 🍺 |
I also prefer Pool for pretty much the same reasons @JamesMcMahon has already stated. I've used it for years and know what it means as I glance over code. It also doesn't compete for auto-completion space unlike Context (ContextMenu in UnityEngine for example) - A feeble argument but I needed to add something unique to the poll ;-) |
Seems like you guys are outvoting me :) |
It's your project Simon so ultimately it's your call. But I will say from experience that sometimes you can stare at a project so long that you see flaws where there are none. 😄 |
What about "Group"? 😉 |
Thanks for your input and opinions. Pool will stay Pool :) |
Old ghosts being reawakened. After experiencing confusion when talking about object pools and Entitas pools and after writing explanations like "a pool is basically a context" I finally decided to rename Pool to Context 😱 |
Hey guys, this is more or less a poll:
What do you guys actually think of the name Pool? I was thinking calling it Context instead of Pool. I started thinking that it might be a better name since we often use it to spilt our games into different 'contexts' like Core, Meta, UI
Let me know what you think, maybe you have even better suggestions...
The text was updated successfully, but these errors were encountered: