Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable ownKeys.list and ownKeys.register #109

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Re-enable ownKeys.list and ownKeys.register #109

merged 5 commits into from
Nov 7, 2023

Conversation

Powersource
Copy link
Contributor

@Powersource Powersource commented Nov 2, 2023 •
edited
Loading

Fixes #100

  • re-enable
  • check readme. maybe mention that the list is always 1 long
  • add test

@Powersource Powersource mentioned this pull request Nov 2, 2023
Closed
Powersource
Powersource commented Nov 2, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@Powersource Powersource marked this pull request as ready for review November 2, 2023 21:01
mixmix
mixmix approved these changes Nov 6, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
index.js
return cb(null, [dmKeyInfo])
})
},
register (key) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be good to call it set .. as it's not just registering, but rather setting the one you will use

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah agree but i think there's so many breaking changes atm, i think it's better to do this at some later point

@socket-security Socket Security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
ssb-box2 7.2.0...7.4.0 None +0/-0 42.3 kB

@Powersource Powersource merged commit 71cd7e0 into master Nov 7, 2023
7 checks passed
@Powersource Powersource deleted the get-own-dm-re-enable branch November 7, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mixmix mixmix mixmix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-enable ownKeys.list and ownKeys.register
2 participants
@Powersource @mixmix