Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring level up-to-date #204

Closed
wants to merge 2 commits into from
Closed

Conversation

christianbundy
Copy link
Contributor

Sorry for the never-ending PRs.

This (like the others) is meant to circumvent Level/leveldown#455 by upgrading level to the most recent version. It passes npm test, but skepticism is warranted.

Thanks for putting up with me! 😉

@myf
Copy link

myf commented May 3, 2018

level-test also needs to be updated eventhough it's a dev dependency. building secure-scuttlebutt itself will break it

@christianbundy
Copy link
Contributor Author

Thanks @myf! I've pushed a PR to that repo as well.

@vweevers
Copy link

vweevers commented May 3, 2018

Do your tests cover usage of level-sublevel? Curious to know if that's compatible with latest level.

@christianbundy
Copy link
Contributor Author

@vweevers Negative. I'm not very familiar with any of the Level components, so any/all expertise is very appreciated.

@christianbundy
Copy link
Contributor Author

Looks like this waas taken care of in 78de3f6, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants