-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Epic: Only use *testing.T in the testing goroutine #2
Comments
I tried to do this on the testRefactor branch but got intangled in the weird functions we return from the setup code... https://github.com/cryptoscope/ssb/tree/testRefactor |
pretty sure I checked muxrpc for this and change the tests. Should also check shs, luigi and margaret, though! |
I just found and fixed a pretty old instance of this in secretstream. I really hope golang/go#28135 will get some traction. |
whoops... I thought i had all instances of ssbc/go-ssb#2
Nope, not active. All instances are resolved but has to be kept in mind. |
#1 (comment)
The text was updated successfully, but these errors were encountered: