Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that MergeableState is clean for mergeable #163

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

himynameisdave
Copy link
Contributor

Resolves #162

Extends the mergeable check to also ensure that the the mergeable state is 'clean'. This ensures that the pull request is truly mergeable. This resolves cases where all status checks have passed (GetMergeable returns true) but review is required on the PR before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] improve mergeable param or add a paramater for Has/Needs code review
1 participant