Skip to content

Commit

Permalink
[FEATURE] ILIAS8 refactoring.
Browse files Browse the repository at this point in the history
  • Loading branch information
thibsy committed Aug 2, 2023
1 parent 395a1cf commit d419397
Show file tree
Hide file tree
Showing 2,460 changed files with 3,658 additions and 229,595 deletions.
2 changes: 1 addition & 1 deletion .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ stages:
review:
extends: .review_deployment
variables:
REVIEW_APP_IMAGE: srsolutions/ilias:7-php7.4-apache
REVIEW_APP_IMAGE: srsolutions/ilias:8-php8.0-apache
REVIEW_APP_DEST: /var/www/html/Customizing/global/plugins/Services/UIComponent/UserInterfaceHook/UserTakeOver
ILIAS_DEVMODE: 1
ILIAS_INSTALL_ARGUMENTS: --no-plugins
Expand Down
18 changes: 16 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,27 @@
# UserTakeOver Changelog

## v4.1.1
## 5.0.0

- Improved over-complicated access-check collection and removed the need for `Closure`'s.
- Improved the impersonation mechanism and removed the need for `Redirect` handlers.
- Replaced all usages of the legacy package `DICTrait` by using proper dependency injection (whenever possible).
- Replaced `ActiveRecord` implementation by using the repository pattern.
- Replaced usages of `filter_input` by using using the ILIAS request wrappers.
- Replaced legacy UI input for the user search by a UI component.
- Replaces all legacy tables by new UI components.
- Replaced all legacy forms by new UI components.
- Removed the `node_modules` directory from the repository along with its config files.
- Added default values for the UserTakeOver plugin settings.
- Added ILIAS 8 compatibility.

## 4.1.1

- Groups which are only restricted to roles are no longer shown in the metabar slate.
- Added a small description about the two kinds of groups to the documentation.
- Fixed missing translation `restricted_to_members` and added bylines to the group-form.
- Added gitlab CI config for creating review-apps.

## v4.1.0
## 4.1.0

- Added new feature to restrict the impersonation of users by global roles.
- Replaced the legacy form implementation of groups by UI components.
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ git clone https://github.com/srsolutionsag/UserTakeOver.git
As ILIAS administrator go to "Administration->Plugins" and install/activate the plugin.

### Requirements
* ILIAS 6.x / 7.x
* PHP >=7.0
* ILIAS 8.x / 8.x
* PHP >=8.0

# ILIAS Plugin SLA
We love and live the philosophy of Open Source Software! Most of our developments, which we develop on behalf of customers or in our own work, we make publicly available to all interested parties free of charge at https://github.com/srsolutionsag.
Expand Down
14 changes: 8 additions & 6 deletions ROADMAP.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,17 @@
This document holds ideas and improvements that could be implemented for this plugin in the future.
(If one of the following points has been implemented mark it checked)

- [ ] Replace the custom multi-select input by an existing or custom UI-Component.

- [ ] Replace the over-complicated access-check collection that consists of nested `Closure`'s by a more simple and
- [x] Replace the over-complicated access-check collection that consists of nested `Closure`'s by a more simple and
explicit approach. This really does cause some headaches.

- [x] Remove the `DICTrait` legacy package by fluxlabs and replace any usages by using proper DI (where possible) and
using the ILIAS DI container `$DIC`.

- [x] Replace the legacy forms (`ilPropertyFormGUI`) by new UI-Components and get rid of any special input magic.

- [ ] Implement the "impersonate search" as custom UI component to get rid of the node modules folder which is currently
being used for ajax autocomplete.

- [ ] Remove the `DICTrait` legacy package by fluxlabs and replace any usages by using proper DI (where possible) and
using the ILIAS DI container `$DIC`.
- [ ] Replace the custom multi-select input by an existing or custom UI-Component.

- [ ] Replace the legacy forms (`ilPropertyFormGUI`) by new UI-Components and get rid of any special input magic.
- [ ] Introduce a local dependency-injection-container to centralize internal dependency management.
103 changes: 0 additions & 103 deletions classes/Access/class.ilObjUserTakeOverAccess.php

This file was deleted.

154 changes: 0 additions & 154 deletions classes/Config/class.ilUserTakeOverARConfig.php

This file was deleted.

Loading

0 comments on commit d419397

Please sign in to comment.