Key and partition selector #123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @sroze |
|
Ping @Nyholm |
Nyholm
reviewed
Apr 4, 2024
| @@ -168,6 +170,16 @@ public function send(Envelope $envelope): Envelope | |||
| $producer->setTimeToLive($this->options['timeToLive']); | |||
| } | |||
|
|
|||
| $partitionStamp = $envelope->last(PartitionStamp::class); | |||
| if (method_exists($interopMessage, 'setPartition') && !is_null($partitionStamp)) { | |||
| $interopMessage->setPartition($partitionStamp->getPartition()); | |||
There was a problem hiding this comment.
What class do you expect here?
Ie, it is not Interop\Queue\Message, right?
There was a problem hiding this comment.
Hi @Nyholm
I expect to have a Enqueue\RdKafka\RdKafkaMessage
I don't remember why I choose to check the method instead of checking the class...
There was a problem hiding this comment.
@Nyholm do you prefer that?
$partitionStamp = $envelope->last(PartitionStamp::class);
if ($interopMessage instanceof RdKafkaMessage && !is_null($partitionStamp)) {
$interopMessage->setPartition($partitionStamp->getPartition());
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add partition stamp for selecting the destination partition in Kafka.
Add key stamp for adding a key to kafka message
Those stamps can be added in a Messenger Middleware to choose the partition or add a key.
I didn't know the dependency versions to run the tests and i found that with this docker composer image the tests didn't throw any warning and are all ok
docker run --rm --interactive --tty --volume $PWD:/app composer:1.10.13 /bin/bash -c "composer install && vendor/bin/phpunit"
#53 (comment)