Minify #85
Closed
Minify #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove dependency on `pymdown-extensions`, so it's handled by the underlying package which requires it (the theme)
Probably because the version pin changed the hash content
|
Interesting idea. Given that we're serving this via nginx with compression (gzip etc.) enabled, does this save us much? The trade-off here is that the generated HTML/JS source is somewhat less readable both in development and production. |
|
There's still some saving to the end user, but I agree it does make dev slightly more annoying, if you're viewing the raw HTML, that is. Will leave this open and think on it some more. |
|
For the sake of easier debugging, and diminishing returns, I think we can leave this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR based on #84, so it was actually possible to install things, I'd suggest not reviewing until that's merged.
Use https://github.com/byrnereese/mkdocs-minify-plugin to minify the site. This only minifies the HTML content, rather than any ancillary scripts.