Skip to content
This repository has been archived by the owner on Jan 25, 2024. It is now read-only.

Note reversed #150

Merged
merged 6 commits into from
Mar 4, 2019
Merged

Note reversed #150

merged 6 commits into from
Mar 4, 2019

Conversation

Skybound1
Copy link
Contributor

This completes Issue #143

@Skybound1
Copy link
Contributor Author

The type checker will probably complain about __members__ being undefined, but this appears to be a bug with the type checker as __members__ was introduced in py 3.6 but that still doesn't recognise it.

python/typeshed#1590, following the github issue links leads to the open python/typeshed#1595

@trickeydan
Copy link
Contributor

Let's ignore the types on this and add an inline comment with a link to the upstream issue and an issue for us so that we don't forget and can use the upstream fix.

trickeydan
trickeydan approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@trickeydan trickeydan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

@Skybound1 Skybound1 merged commit 393cc91 into master Mar 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the note_reversed branch March 4, 2019 20:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trickeydan trickeydan trickeydan approved these changes

@kierdavis kierdavis kierdavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Skybound1 @trickeydan @kierdavis