stellar#4728: review feedback, changed is_payment db type to boolean,…

… nullable, no default

services/horizon/internal/db2/history/operation.go

@@ -247,7 +247,7 @@ func (q *OperationsQ) OnlyPayments() *OperationsQ {
 			xdr.OperationTypePathPaymentStrictSend,
 			xdr.OperationTypeAccountMerge,
 		}},
-		sq.Eq{"hop.is_payment": 1}})
+		sq.Eq{"hop.is_payment": true}})
 
 	return q
 }

services/horizon/internal/db2/history/operation_batch_insert_builder.go

@@ -52,10 +52,6 @@ func (i *operationBatchInsertBuilder) Add(
 	sourceAccountMuxed null.String,
 	isPayment bool,
 ) error {
-	dbIsPayment := 0
-	if isPayment {
-		dbIsPayment = 1
-	}
 	return i.builder.Row(ctx, map[string]interface{}{
 		"id":                   id,
 		"transaction_id":       transactionID,
@@ -64,7 +60,7 @@ func (i *operationBatchInsertBuilder) Add(
 		"details":              details,
 		"source_account":       sourceAccount,
 		"source_account_muxed": sourceAccountMuxed,
-		"is_payment":           dbIsPayment,
+		"is_payment":           isPayment,
 	})
 
 }

services/horizon/internal/db2/schema/migrations/64_add_payment_flag_history_ops.sql

@@ -1,6 +1,6 @@
 -- +migrate Up
 
-ALTER TABLE history_operations ADD is_payment smallint DEFAULT 0;
+ALTER TABLE history_operations ADD is_payment boolean;
 CREATE INDEX "index_history_operations_on_is_payment" ON history_operations USING btree (is_payment);
 
 -- +migrate Down

services/horizon/internal/ingest/processors/operations_processor.go

@@ -714,7 +714,7 @@ func (operation *transactionOperationWrapper) Details() (map[string]interface{},
 //
 // SAC events that involve asset balance changes follow some standard data formats:
 //     The 'amount' in the event is expressed as Int128Parts, however it's expected that it's value will not be signed.
-//     It represents a absolute delta, the event type can provide the context of whether an amount 
+//     It represents a absolute delta, the event type can provide the context of whether an amount
 //     was considered incremental or decreental, i.e. credit or debit to a balance.
 //
 func (operation *transactionOperationWrapper) parseAssetBalanceChangesFromContractEvents() ([]map[string]interface{}, error) {

services/horizon/internal/test/scenarios/account_merge-horizon.sql

@@ -358,7 +358,7 @@ CREATE TABLE history_operations (
     type integer NOT NULL,
     details jsonb,
     source_account character varying(64) DEFAULT ''::character varying NOT NULL,
-    is_payment smallint default 0
+    is_payment boolean
 );
 
 
@@ -580,9 +580,9 @@ SELECT pg_catalog.setval('history_operation_participants_id_seq', 6, true);
 -- Data for Name: history_operations; Type: TABLE DATA; Schema: public; Owner: -
 --
 
-INSERT INTO history_operations VALUES (12884905985, 12884905984, 1, 8, '{"into": "GA5WBPYA5Y4WAEHXWR2UKO2UO4BUGHUQ74EUPKON2QHV4WRHOIRNKKH2", "account": "GCXKG6RN4ONIEPCMNFB732A436Z5PNDSRLGWK7GBLCMQLIFO4S7EYWVU"}', 'GCXKG6RN4ONIEPCMNFB732A436Z5PNDSRLGWK7GBLCMQLIFO4S7EYWVU', 1);
-INSERT INTO history_operations VALUES (8589938689, 8589938688, 1, 0, '{"funder": "GBRPYHIL2CI3FNQ4BXLFMNDLFJUNPU2HY3ZMFSHONUCEOASW7QC7OX2H", "account": "GCXKG6RN4ONIEPCMNFB732A436Z5PNDSRLGWK7GBLCMQLIFO4S7EYWVU", "starting_balance": "1000.0000000"}', 'GBRPYHIL2CI3FNQ4BXLFMNDLFJUNPU2HY3ZMFSHONUCEOASW7QC7OX2H', 1);
-INSERT INTO history_operations VALUES (8589942785, 8589942784, 1, 0, '{"funder": "GBRPYHIL2CI3FNQ4BXLFMNDLFJUNPU2HY3ZMFSHONUCEOASW7QC7OX2H", "account": "GA5WBPYA5Y4WAEHXWR2UKO2UO4BUGHUQ74EUPKON2QHV4WRHOIRNKKH2", "starting_balance": "1000.0000000"}', 'GBRPYHIL2CI3FNQ4BXLFMNDLFJUNPU2HY3ZMFSHONUCEOASW7QC7OX2H', 1);
+INSERT INTO history_operations VALUES (12884905985, 12884905984, 1, 8, '{"into": "GA5WBPYA5Y4WAEHXWR2UKO2UO4BUGHUQ74EUPKON2QHV4WRHOIRNKKH2", "account": "GCXKG6RN4ONIEPCMNFB732A436Z5PNDSRLGWK7GBLCMQLIFO4S7EYWVU"}', 'GCXKG6RN4ONIEPCMNFB732A436Z5PNDSRLGWK7GBLCMQLIFO4S7EYWVU', true);
+INSERT INTO history_operations VALUES (8589938689, 8589938688, 1, 0, '{"funder": "GBRPYHIL2CI3FNQ4BXLFMNDLFJUNPU2HY3ZMFSHONUCEOASW7QC7OX2H", "account": "GCXKG6RN4ONIEPCMNFB732A436Z5PNDSRLGWK7GBLCMQLIFO4S7EYWVU", "starting_balance": "1000.0000000"}', 'GBRPYHIL2CI3FNQ4BXLFMNDLFJUNPU2HY3ZMFSHONUCEOASW7QC7OX2H', true);
+INSERT INTO history_operations VALUES (8589942785, 8589942784, 1, 0, '{"funder": "GBRPYHIL2CI3FNQ4BXLFMNDLFJUNPU2HY3ZMFSHONUCEOASW7QC7OX2H", "account": "GA5WBPYA5Y4WAEHXWR2UKO2UO4BUGHUQ74EUPKON2QHV4WRHOIRNKKH2", "starting_balance": "1000.0000000"}', 'GBRPYHIL2CI3FNQ4BXLFMNDLFJUNPU2HY3ZMFSHONUCEOASW7QC7OX2H', true);
 
 
 --

services/horizon/internal/test/scenarios/base-horizon.sql

@@ -488,6 +488,7 @@ ALTER SEQUENCE history_operation_participants_id_seq OWNED BY history_operation_
 --
 -- Name: history_operations; Type: TABLE; Schema: public; Owner: -
 --
+-- added is_payment=false default to schema, rather than change insert lines
 
 CREATE TABLE history_operations (
     id bigint NOT NULL,
@@ -496,7 +497,7 @@ CREATE TABLE history_operations (
     type integer NOT NULL,
     details jsonb,
     source_account character varying(64) DEFAULT ''::character varying NOT NULL,
-    is_payment smallint default 0
+    is_payment boolean default false
 );
 
 

services/horizon/internal/test/scenarios/failed_transactions-horizon.sql

@@ -351,6 +351,7 @@ ALTER SEQUENCE history_operation_participants_id_seq OWNED BY history_operation_
 --
 -- Name: history_operations; Type: TABLE; Schema: public; Owner: -
 --
+-- added is_payment=false default to schema, rather than change insert lines
 
 CREATE TABLE history_operations (
     id bigint NOT NULL,
@@ -359,7 +360,7 @@ CREATE TABLE history_operations (
     type integer NOT NULL,
     details jsonb,
     source_account character varying(64) DEFAULT ''::character varying NOT NULL,
-    is_payment smallint default 0
+    is_payment boolean default false
 );
 
 

services/horizon/internal/test/scenarios/ingest_asset_stats-horizon.sql

@@ -350,6 +350,7 @@ ALTER SEQUENCE history_operation_participants_id_seq OWNED BY history_operation_
 --
 -- Name: history_operations; Type: TABLE; Schema: public; Owner: -
 --
+-- added is_payment=false default to schema, rather than change insert lines
 
 CREATE TABLE history_operations (
     id bigint NOT NULL,
@@ -358,10 +359,9 @@ CREATE TABLE history_operations (
     type integer NOT NULL,
     details jsonb,
     source_account character varying(64) DEFAULT ''::character varying NOT NULL,
-    is_payment smallint default 0
+    is_payment boolean default false
 );
 
-
 --
 -- Name: history_trades; Type: TABLE; Schema: public; Owner: -
 --

services/horizon/internal/test/scenarios/kahuna-horizon.sql

@@ -489,6 +489,7 @@ ALTER SEQUENCE history_operation_participants_id_seq OWNED BY history_operation_
 --
 -- Name: history_operations; Type: TABLE; Schema: public; Owner: -
 --
+-- added is_payment=false default to schema, rather than change insert lines
 
 CREATE TABLE history_operations (
     id bigint NOT NULL,
@@ -497,7 +498,7 @@ CREATE TABLE history_operations (
     type integer NOT NULL,
     details jsonb,
     source_account character varying(64) DEFAULT ''::character varying NOT NULL,
-    is_payment smallint default 0
+    is_payment boolean default false
 );
 
 

services/horizon/internal/test/scenarios/offer_ids-horizon.sql

@@ -350,6 +350,7 @@ ALTER SEQUENCE history_operation_participants_id_seq OWNED BY history_operation_
 --
 -- Name: history_operations; Type: TABLE; Schema: public; Owner: -
 --
+-- added is_payment=false default to schema, rather than change insert lines
 
 CREATE TABLE history_operations (
     id bigint NOT NULL,
@@ -358,7 +359,7 @@ CREATE TABLE history_operations (
     type integer NOT NULL,
     details jsonb,
     source_account character varying(64) DEFAULT ''::character varying NOT NULL
-    is_payment smallint default 0
+    is_payment boolean default false
 );
 
 

services/horizon/internal/test/scenarios/operation_fee_stats_1-horizon.sql

@@ -350,6 +350,7 @@ ALTER SEQUENCE history_operation_participants_id_seq OWNED BY history_operation_
 --
 -- Name: history_operations; Type: TABLE; Schema: public; Owner: -
 --
+-- added is_payment=false default to schema, rather than change insert lines
 
 CREATE TABLE history_operations (
     id bigint NOT NULL,
@@ -358,7 +359,7 @@ CREATE TABLE history_operations (
     type integer NOT NULL,
     details jsonb,
     source_account character varying(64) DEFAULT ''::character varying NOT NULL,
-    is_payment smallint default 0
+    is_payment boolean default false
 );
 
 

services/horizon/internal/test/scenarios/operation_fee_stats_2-horizon.sql

@@ -350,6 +350,7 @@ ALTER SEQUENCE history_operation_participants_id_seq OWNED BY history_operation_
 --
 -- Name: history_operations; Type: TABLE; Schema: public; Owner: -
 --
+-- added is_payment=false default to schema, rather than change insert lines
 
 CREATE TABLE history_operations (
     id bigint NOT NULL,
@@ -358,7 +359,7 @@ CREATE TABLE history_operations (
     type integer NOT NULL,
     details jsonb,
     source_account character varying(64) DEFAULT ''::character varying NOT NULL,
-    is_payment smallint default 0
+    is_payment boolean default false
 );
 
 

services/horizon/internal/test/scenarios/operation_fee_stats_3-horizon.sql

@@ -350,6 +350,7 @@ ALTER SEQUENCE history_operation_participants_id_seq OWNED BY history_operation_
 --
 -- Name: history_operations; Type: TABLE; Schema: public; Owner: -
 --
+-- added is_payment=false default to schema, rather than change insert lines
 
 CREATE TABLE history_operations (
     id bigint NOT NULL,
@@ -358,7 +359,7 @@ CREATE TABLE history_operations (
     type integer NOT NULL,
     details jsonb,
     source_account character varying(64) DEFAULT ''::character varying NOT NULL,
-    is_payment smallint default 0
+    is_payment boolean default false
 );
 
 

services/horizon/internal/test/scenarios/pathed_payment-horizon.sql

@@ -351,6 +351,7 @@ ALTER SEQUENCE history_operation_participants_id_seq OWNED BY history_operation_
 --
 -- Name: history_operations; Type: TABLE; Schema: public; Owner: -
 --
+-- added is_payment=false default to schema, rather than change insert lines
 
 CREATE TABLE history_operations (
     id bigint NOT NULL,
@@ -359,7 +360,7 @@ CREATE TABLE history_operations (
     type integer NOT NULL,
     details jsonb,
     source_account character varying(64) DEFAULT ''::character varying NOT NULL,
-    is_payment smallint default 0
+    is_payment boolean default false
 );
 
 

services/horizon/internal/test/scenarios/paths_strict_send-horizon.sql

@@ -373,6 +373,7 @@ ALTER SEQUENCE history_operation_participants_id_seq OWNED BY history_operation_
 --
 -- Name: history_operations; Type: TABLE; Schema: public; Owner: -
 --
+-- added is_payment=false default to schema, rather than change insert lines
 
 CREATE TABLE history_operations (
     id bigint NOT NULL,
@@ -381,7 +382,7 @@ CREATE TABLE history_operations (
     type integer NOT NULL,
     details jsonb,
     source_account character varying(64) DEFAULT ''::character varying NOT NULL,
-    is_payment smallint default 0
+    is_payment boolean default false
 );