stellar#4909: review feedback, cleanup

sreuland · Oct 25, 2023 · dd30b6a · dd30b6a
1 parent 9a4d0eb
commit dd30b6a
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 12 deletions.
diff --git a/services/horizon/docker/verify-range/dependencies b/services/horizon/docker/verify-range/dependencies
@@ -20,7 +20,4 @@ cd stellar-go
 # Below ensures we also fetch PR refs
 git config --add remote.origin.fetch "+refs/pull/*/head:refs/remotes/origin/pull/*"
 git fetch --force --quiet origin
-/usr/local/go/bin/go build -v ./services/horizon/.
-
-
-
+/usr/local/go/bin/go build -v ./services/horizon/.
diff --git a/services/horizon/internal/db2/history/fee_bump_scenario.go b/services/horizon/internal/db2/history/fee_bump_scenario.go
@@ -4,7 +4,6 @@ import (
 	"context"
 	"encoding/hex"
 	"encoding/json"
-	"fmt"
 	"testing"
 	"time"
 
@@ -271,7 +270,6 @@ func FeeBumpScenario(tt *test.T, q *Q, successful bool) FeeBumpFixture {
 		"bump_to": "98",
 	})
 
-	fmt.Print(string(details))
 	tt.Assert.NoError(err)
 
 	tt.Assert.NoError(opBuilder.Add(

diff --git a/services/horizon/internal/ingest/processors/ledgers_processor.go b/services/horizon/internal/ingest/processors/ledgers_processor.go
@@ -10,7 +10,7 @@ import (
 	"github.com/stellar/go/xdr"
 )
 
-type LedgerInfo struct {
+type ledgerInfo struct {
 	header         xdr.LedgerHeaderHistoryEntry
 	successTxCount int
 	failedTxCount  int
@@ -20,23 +20,23 @@ type LedgerInfo struct {
 
 type LedgersProcessor struct {
 	batch         history.LedgerBatchInsertBuilder
-	ledgers       map[uint32]*LedgerInfo
+	ledgers       map[uint32]*ledgerInfo
 	ingestVersion int
 }
 
 func NewLedgerProcessor(batch history.LedgerBatchInsertBuilder, ingestVersion int) *LedgersProcessor {
 	return &LedgersProcessor{
 		batch:         batch,
-		ledgers:       map[uint32]*LedgerInfo{},
+		ledgers:       map[uint32]*ledgerInfo{},
 		ingestVersion: ingestVersion,
 	}
 }
 
-func (p *LedgersProcessor) ProcessLedger(lcm xdr.LedgerCloseMeta) *LedgerInfo {
+func (p *LedgersProcessor) ProcessLedger(lcm xdr.LedgerCloseMeta) *ledgerInfo {
 	sequence := lcm.LedgerSequence()
 	entry, ok := p.ledgers[sequence]
 	if !ok {
-		entry = &LedgerInfo{header: lcm.LedgerHeaderHistoryEntry()}
+		entry = &ledgerInfo{header: lcm.LedgerHeaderHistoryEntry()}
 		p.ledgers[sequence] = entry
 	}
 	return entry

diff --git a/support/db/internal_test.go b/support/db/internal_test.go
@@ -7,7 +7,7 @@ const testSchema = `
 CREATE TABLE  IF NOT EXISTS people (
     name character varying NOT NULL,
     hunger_level integer NOT NULL,
-	json_value jsonb,
+    json_value jsonb,
     PRIMARY KEY (name)
 );
 DELETE FROM people;