stellar#4789: bumped p20 enabled integration tests to use release can…

…didate git ref for soroban enabled core
sreuland · Mar 28, 2023 · bbccd9c · bbccd9c
1 parent ddcb0c7
commit bbccd9c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.github/workflows/horizon.yml b/.github/workflows/horizon.yml
@@ -34,8 +34,8 @@ jobs:
     env:
       HORIZON_INTEGRATION_TESTS_ENABLED: true
       HORIZON_INTEGRATION_TESTS_CORE_MAX_SUPPORTED_PROTOCOL: ${{ matrix.protocol-version }}
-      PROTOCOL_20_CORE_DEBIAN_PKG_VERSION: 19.8.1-1243.53ea43ace.focal~soroban
-      PROTOCOL_20_CORE_DOCKER_IMG: 2opremio/stellar-core:19.8.1-1243.53ea43ace.focal-soroban
+      PROTOCOL_20_CORE_DEBIAN_PKG_VERSION: 19.8.1-1246.064a2787a.focal~soroban
+      PROTOCOL_20_CORE_DOCKER_IMG: sreuland/stellar-core:19.8.1-1246.064a2787a.focal-soroban
       PROTOCOL_19_CORE_DEBIAN_PKG_VERSION: 19.5.0-1108.ca2fb0605.focal
       PROTOCOL_19_CORE_DOCKER_IMG: stellar/stellar-core:19.5.0-1108.ca2fb0605.focal
       PGHOST: localhost

diff --git a/ingest/ledger_transaction.go b/ingest/ledger_transaction.go
@@ -167,12 +167,18 @@ func (t *LedgerTransaction) GetOperationEvents(operationIndex uint32) ([]xdr.Dia
 	case 3:
 		diagnosticEventsByOperation := t.UnsafeMeta.MustV3().DiagnosticEvents
 		if int(operationIndex) < len(diagnosticEventsByOperation) {
+			// all contract events and diag events for a single operation(by it's index in the tx) were available  
+			// in tx meta's DiagnosticEvents, no need to look anywhere else for events
 			return diagnosticEventsByOperation[operationIndex].Events, nil
 		}
 		eventsByOperation := t.UnsafeMeta.MustV3().Events
 		if int(operationIndex) >= len(eventsByOperation) {
+			// no events were present in this tx meta
 			return nil, nil
 		}
+
+		// tx meta only provided contract events, no diagnostic events, we convert the contract
+		// event to a diagnostic event, to fit the response interface. 
 		events := eventsByOperation[operationIndex].Events
 		diagnosticEvents := make([]xdr.DiagnosticEvent, len(events))
 		for i, event := range events {