add timeout error message for mapping test #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YemreGurses
requested changes
Nov 26, 2024
| ) | ||
| ) | ||
| ) | ||
| } { |
There was a problem hiding this comment.
I think we should put these logic inside of a method and then call it under testMappingWithJob?
| """Status Code: 408 | ||
| |Type: https://tofhir.io/errors/RequestTimeout | ||
| |Title: Request Timeout | ||
| |Detail: There are too many rows in the data source CSV. |
There was a problem hiding this comment.
Let 's update this message: The server could not complete the test because of the large data. Try increasing the timeout config and test again.
| entity = HttpEntity.Strict( | ||
| ContentTypes.`application/json`, | ||
| ByteString( | ||
| """Status Code: 408 |
There was a problem hiding this comment.
Instead of writing plain string here, can you add a new case class to ToFhirError file for timeout errors. And use that class to construct the error.
YemreGurses
force-pushed
the
mapping-testing-error-display
branch
from
6eb450f
to
830b54d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.