Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create go.mod and fix go 1.14 compile error #21

Closed
wants to merge 4 commits into from

Conversation

artheus
Copy link

@artheus artheus commented Apr 27, 2020

Created a go.mod, since Go Modules are now standard practice.

Fixed the Go 1.14 compiler error, which was uuid.NewV4() no longer returning an error.

@artheus
Copy link
Author

artheus commented Apr 27, 2020

I decided to change the uuid library to github.com/google/uuid as it seems like a more stable choice. And the developers of github.com/satori/go.uuid basically told developers to "live with it" after the unannounced breaking change of their library was made. Please see satori/go.uuid#66

@kuba--
Copy link

kuba-- commented Apr 27, 2020

@artheus - this project is not longer maintained (mainly because source{d} as company was closed).
So, I suggest to move/close/fork this repo to the new org.

@artheus
Copy link
Author

artheus commented Apr 28, 2020 via email

@artheus
Copy link
Author

artheus commented Apr 28, 2020

@kuba-- @jfontan @smola @Serabe Please see https://github.com/go-mq/mq and please tell me if there is something you would like for me to change to give you more credit for the work you've put into this.

@artheus artheus closed this Apr 28, 2020
@smola
Copy link
Contributor

smola commented Jun 5, 2020

@marnovo Maybe we can update README to suggest @artheus fork?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants