This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
Improvement/memory consumption new packfile parser #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It uses less memory and is faster as slices don't have to be converted from/to MemoryObject and they are indexed by offset. Signed-off-by: Javi Fontan <[email protected]>
* a new hasher is created when needed * delete unused fields * base content is no longer kept in memory Signed-off-by: Javi Fontan <[email protected]>
ajnavarro
approved these changes
Aug 14, 2018
Signed-off-by: Javi Fontan <[email protected]>
|
Improved a bit the performance skipping deltas that already had the hash computed. This happens when the delta is used again as base but is not in cache. Now: |
jfontan
changed the title
ajnavarro
approved these changes
Aug 16, 2018
erizocosmico
approved these changes
Aug 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plumbing: add buffer cache and use it in packfile parser: It uses less memory and is faster as slices don't have to be converted from/to
MemoryObjectand they are indexed by offset.plumbing/pacfile: tidy up objectInfo struct
Testing clone of a local repo with a 1.1 Gb packfile and 3 million objects:
Before:
Now: