Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid namespace in phpdoc (\PHP_CodeSniffer\Files\File) #3885

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

mzk
Copy link
Contributor

@mzk mzk commented Sep 11, 2023

The invalid phpdoc namespace fixed.

Description

Suggested changelog entry

Related issues/external references

Fixes #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change. (Normalize and fix phpdoc typehints across the code #3256 similar)
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.
  • [Required for new files] I have added any new files to the package.xml file.

Copy link
Contributor

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mzk Thanks for this PR. The alignment of the parameters in the docblocks will need to be fixed though before this can be merged.

@mzk
Copy link
Contributor Author

mzk commented Sep 11, 2023

@jrfnl Done, thx.

Copy link
Contributor

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that up! Merging now.

@jrfnl jrfnl merged commit 7566b4d into squizlabs:master Sep 11, 2023
@jrfnl jrfnl added this to the 3.8.0 milestone Sep 11, 2023
@mzk mzk deleted the os-fix-phpdoc branch September 11, 2023 12:38
@jrfnl
Copy link
Contributor

jrfnl commented Dec 8, 2023

FYI: this fix is included in today's PHP_CodeSniffer 3.8.0 release.

As per #3932, development on PHP_CodeSniffer will continue in the PHPCSStandards/PHP_CodeSniffer repository. If you want to stay informed, you may want to start "watching" that repo (or watching releases from that repo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants