-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): change filter arguments to match PascalCase #3879
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @simonsan! Could you also make the same change on line 1406 (same file) ?
@jrfnl Done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @simonsan !
The changelog normally contains the full name of the contributor. Would you mind sharing yours ?
Hey there, yes, as a privacy activist I wouldn't share my full name on the internet. I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights). 👍🏽 |
Thanks for letting me know @simonsan and I fully respect that. I'll just credit you by your GitHub handle in that case (presuming that's okay ?). |
The filter names are case-sensitive (depending on OS), so the help texts should display the case which will be accepted on all OS-es.
FYI: this fix is included in today's PHP_CodeSniffer 3.8.0 release. As per #3932, development on PHP_CodeSniffer will continue in the PHPCSStandards/PHP_CodeSniffer repository. If you want to stay informed, you may want to start "watching" that repo (or watching releases from that repo). |
Description
It fixes documentation of the command-line interface for the
filter
command.Suggested changelog entry
Change documentation of filter command to match internally used PascalCase
Related issues/external references
Fixes #3877
Types of changes
PR checklist