Auto-add fullstop to @throws if rule is used

[pascalheidmann]

Automatic fix for cases like

/**
 * @throws FoobarException throws
*/

will be

/**
 * @throws FoobarException throws.
*/

[jrfnl]

I have no opinion on the merit of this PR, just left some comments to get it into a mergable state in case the PR would be considered as viable.

[jrfnl]

Not sure what you're trying to do here, but this change should be undone as this is the test file for an unrelated sniff.

[pascalheidmann]

I'm not really sure what changed either but without this change this unit test fails...

[jrfnl]

How did you run the tests to come to that conclusion ?
The last CI build passed without problems, so unless you changed something either in the test files or in the sniff, there should be no reason why the tests would fail.

[jrfnl]

FYI - this particular test is skipped in a few cases, could it be that the way you are running the tests falls under the "skip" conditions, but isn't identified correctly ? In that case, fixing the condition would be a good thing, but that should still be done in a separate PR as it would constitute a different decision point than the decision for whether or not to accept this PR.

PHP_CodeSniffer/src/Standards/Generic/Tests/Files/ExecutableFileUnitTest.php

Lines 23 to 30 in f268ca4

	protected function shouldSkipTest()
	{
	// PEAR doesn't preserve the executable flag, so skip
	// tests when running in a PEAR install.
	// Also skip on Windows which doesn't have the concept of executable files.
	return ($GLOBALS['PHP_CODESNIFFER_PEAR'] || (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN'));
	}//end shouldSkipTest()

[pascalheidmann]

@jrfnl comments are appreciated :)
As stated the change within the phpunit test case is needed as it otherwise fails but if you have an idea/suggestion I really welcome those too.

edit: looks like the test is broken for some time and unrelated to this PR.

[gsherwood]

Thanks for the PR, but this is not the kind of auto-fix I like PHPCS to do as I can't be sure a full stop is required here. Changing comments is something I think is best left to manual code review.