PHP4-style typed properties not tokenized correctly #2804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typed properties are explicitly also supported for PHP 4-style properties using just the `var` or `static` keyword. However, in that case, the nullable indicator `?` was not converted from `T_INLINE_THEN` to `T_NULLABLE`. Fixed now. Includes unit tests via the `File::getMemberProperties()` method. Ref: https://wiki.php.net/rfc/typed_properties_v2
gsherwood
changed the title
gsherwood
changed the title
|
Thanks |
jrfnl
deleted the
feature/tokenizer-bug-php-74-typed-properties-nullable-with-var
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typed properties are explicitly also supported for PHP 4-style properties using just the
varorstatickeyword.However, in that case, the nullable indicator
?was not converted fromT_INLINE_THENtoT_NULLABLE.Fixed now.
Includes unit tests via the
File::getMemberProperties()method.Ref: https://wiki.php.net/rfc/typed_properties_v2